Various updates to macports module

[newtonne]

SUMMARY

• Add support for installing specific variants of a port.
• Add support for using yaml lists with name parameter, rather than comma-separated lists.
• Add to and clarify documentation and examples.
• Use Macports nomenclature:
  • s/package/port/g
  • Rename update_cache to update_ports but keep update_cache as an alias. Remove undocumented update-cache alias.
  • Remove undocumented pkg alias for name. Replace with port alias and document it.
• Print stdout and stderr output if port sync fails.
• Print stderr output, rather than stdout, if port install/uninstall/activate/deactivate fail.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

macports module

ANSIBLE VERSION

ansible 2.7.0.dev0 (macports-various-updates cffffe3a60) last updated 2018/08/24 01:42:11 (GMT +100)
  config file = None
  configured module search path = ['/Users/newtonne/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/newtonne/Projects/ansible/lib/ansible
  executable location = /Users/newtonne/Projects/ansible/bin/ansible
  python version = 3.6.6 (default, Jun 28 2018, 05:43:53) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

ADDITIONAL INFORMATION

I realise there are quite a few changes in here. Let me know if you want me to split them out into separate PRs.

[ansibot]

cc @jcftang
click here for bot help

[ansibot]

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/macports.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/macports.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/macports.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/macports.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/packaging/os/macports.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/packaging/os/macports.py:0:0: E305 DOCUMENTATION.options.variant.description.1: expected str @ data['options']['variant']['description'][1]. Got {'C(variant) is only supported with state': 'I(installed)/I(present).'}
lib/ansible/modules/packaging/os/macports.py:0:0: E305 DOCUMENTATION.options.variant.type: not a valid value for dictionary value @ data['options']['variant']['type']. Got 'string'
lib/ansible/modules/packaging/os/macports.py:0:0: E309 version_added for new option (variant) should be 2.7. Currently 0.0
test/sanity/validate-modules/ignore.txt:976:1: A102 Remove since "lib/ansible/modules/packaging/os/macports.py" passes "E322" test

click here for bot help

[ansibot]

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:976:1: A102 Remove since "lib/ansible/modules/packaging/os/macports.py" passes "E322" test

click here for bot help

[ansibot]

cc @mattclay
click here for bot help

[jcftang]

LGTM, this module needed some updating

[newtonne]

Thanks, @jcftang. Ideally, it would be updated even further, but I just needed these changes for now.

[resmo]

please see bot help to help triaging the PRs for the next time. Thanks.

LGTM

[resmo]

thanks again!

[newtonne]

please see bot help to help triaging the PRs for the next time. Thanks.

No worries. Was it just adding theready_for_review label that I missed?

thanks again!

Thanks for merging!