Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect default value for shutdown_command #44607

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Fix incorrect default value for shutdown_command #44607

merged 1 commit into from
Aug 24, 2018

Conversation

ccoley
Copy link
Contributor

@ccoley ccoley commented Aug 24, 2018

SUMMARY

Fix the new reboot action plugin so that the default value for shutdown_command is pulled from SHUTDOWN_COMMANDS instead of SHUTDOWN_COMMAND_ARGS.

The reboot action was just merged in #35205 so I doubt anyone has encountered this issue yet.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

Reboot action plugin.

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 24, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Aug 24, 2018
@samdoran samdoran self-assigned this Aug 24, 2018
samdoran
samdoran approved these changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This didn't come up during testing because all the systems I tested against match a key in SHUTDOWN_COMMANDS.

@samdoran samdoran merged commit ce5530e into ansible:devel Aug 24, 2018
@ccoley ccoley deleted the fix-reboot-plugin branch August 24, 2018 20:27
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

@samdoran samdoran samdoran approved these changes

@nitzmahone nitzmahone Awaiting requested review from nitzmahone

@dagwieers dagwieers Awaiting requested review from dagwieers

@abadger abadger Awaiting requested review from abadger

Assignees

@samdoran samdoran

Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ccoley @achinthagunasekara @samdoran @webknjaz @ansibot