Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNS Made Easy fix locale for date string #44624

Merged
merged 2 commits into from
May 26, 2019
Merged

DNS Made Easy fix locale for date string #44624

merged 2 commits into from
May 26, 2019

Conversation

EagleIJoe
Copy link
Contributor

SUMMARY

This fix forces the current date string to be generated in en_US. The DNS Made Easy API requires the date format to be sent with English locale.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

The applies solely to the dnsmadeeasy module.

ANSIBLE VERSION
ansible 2.7.0.dev0 (dme_fix_time_locale 3100a7b85b) last updated 2018/08/24 11:04:26 (GMT +200)

@EagleIJoe EagleIJoe changed the title Dme fix time locale DNS Made Easy fix locale for date string Aug 24, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

@EagleIJoe this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/net_tools/dnsmadeeasy.py:403:40: E231 missing whitespace after ','

click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. merge_commit This PR contains at least one merge commit. Please resolve! module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. net_tools Net-tools category new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 24, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

@EagleIJoe this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 24, 2018
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Aug 24, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

cc @briceburg
click here for bot help

@ansibot ansibot added small_patch community_review In order to be merged, this PR must follow the community review workflow. and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 24, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Aug 24, 2018
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed new_contributor This PR is the first contribution by a new community member. labels Sep 5, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 21, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) support:community This issue/PR relates to code supported by the Ansible community. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 7, 2018
@ansibot ansibot removed the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Nov 9, 2018
@EagleIJoe EagleIJoe closed this May 22, 2019
@EagleIJoe EagleIJoe reopened this May 22, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 22, 2019
@EagleIJoe EagleIJoe force-pushed the dme_fix_time_locale branch 2 times, most recently from b13439a to 29de3ce Compare May 26, 2019 13:58
felixfontein
felixfontein approved these changes May 26, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides this, looks good to me.

changelogs/fragments/44624-dnsmadeeasy-fix_locale.yaml Outdated Show resolved Hide resolved
@EagleIJoe
Force C locale for time string
b9f861f 
Signed-off-by: Martin Adler <1208749+EagleIJoe@users.noreply.github.com>
@EagleIJoe @felixfontein
Update changelogs/fragments/44624-dnsmadeeasy-fix_locale.yaml
4ca7481 
Co-Authored-By: Felix Fontein <felix@fontein.de>
felixfontein
felixfontein approved these changes May 26, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

resmo
resmo approved these changes May 26, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@resmo resmo merged commit d5ab712 into ansible:devel May 26, 2019
@EagleIJoe EagleIJoe deleted the dme_fix_time_locale branch May 28, 2019 08:42
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@EagleIJoe @ansibot @resmo @felixfontein @samdoran