Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve netapp_e_lun_mapping module and documentation #44666

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Improve netapp_e_lun_mapping module and documentation #44666

merged 1 commit into from
Aug 28, 2018

Conversation

ndswartz
Copy link
Contributor

SUMMARY

Fixes: #44124

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

netapp_e_lun_mapping

ANSIBLE VERSION
ansible 2.7.0.dev0 (lun_mapping_pub_update faac31d6e6) last updated 2018/08/24 15:20:12 (GMT -500)
  config file = None
  configured module search path = [u'/home/swartzn/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/swartzn/ansible-dev/lib/ansible
  executable location = /home/swartzn/ansible-dev/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]

@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

cc @amit0701 @carchi8py @hulquest @lmprice @schmots1
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp new_contributor This PR is the first contribution by a new community member. owner_pr This PR is made by the module's maintainer. storage support:community This issue/PR relates to code supported by the Ansible community. labels Aug 24, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 24, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_lun_mapping.py:61:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/storage/netapp/netapp_e_lun_mapping.py:0:0: E305 DOCUMENTATION.author: required key not provided @ data['author']. Got None
lib/ansible/modules/storage/netapp/netapp_e_lun_mapping.py:0:0: E305 DOCUMENTATION.authors: extra keys not allowed @ data['authors']. Got ['Nathan Swartz (@ndswartz)', 'Kevin Hulquest (@hulquest)']
lib/ansible/modules/storage/netapp/netapp_e_lun_mapping.py:0:0: E309 version_added for new option (log_path) should be 2.7. Currently 0.0

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 24, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 25, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 25, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_lun_mapping.py:54:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_lun_mapping.py:0:0: E322 "log_path" is listed in the argument_spec, but not documented in the module

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 25, 2018
@ndswartz ndswartz closed this Aug 25, 2018
@ndswartz ndswartz reopened this Aug 25, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 25, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 25, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_lun_mapping.py:54:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/netapp_e_lun_mapping.py:0:0: E322 "log_path" is listed in the argument_spec, but not documented in the module

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 25, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 25, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Aug 27, 2018
@gundalow gundalow merged commit 06a5e6a into ansible:devel Aug 28, 2018
@gundalow gundalow mentioned this pull request Aug 28, 2018
Closed
@ndswartz ndswartz deleted the lun_mapping_pub branch August 28, 2018 13:56
@lmprice lmprice mentioned this pull request Aug 28, 2018
Merged
ndswartz pushed a commit to ndswartz/ansible that referenced this pull request Aug 28, 2018
@swartzn
Fixed netapp_e_lun_mapping options for backwards compatibility.
84ddc73 
Readd lun and target_type as deprecated options.

Note: lun and target_type were removed in patch ansible#44666 since they were
no longer needed for the logic in the module.  However, this cause will
cause existing playbooks utilizing these options to break.
gundalow pushed a commit that referenced this pull request Aug 30, 2018
@gundalow
Fixed netapp_e_lun_mapping options for backwards compatibilitiy (#44769)
b0cee34 
* Fixed netapp_e_lun_mapping options for backwards compatibility.

Readd lun and target_type as deprecated options.

Note: lun and target_type were removed in patch #44666 since they were
no longer needed for the logic in the module.  However, this cause will
cause existing playbooks utilizing these options to break.

* Add lun specification and target_type verification for netapp_e_lun_mapping
@gundalow
Copy link
Contributor

Hi,
I'm randomly selecting some PRs to see how it was for you, with the aim of making it easier for future contributors. As a new contributor I'm particularly interested as you don't have any prior knowledge of the Ansible process.

  1. Generally speaking, how was the process for you?
  2. Did it make sense what to do to progress the PR?
  3. Did you read any of the developer (dev_guide) or contributor documentation?
  4. What in the documentation was useful or confusing, missing or could be improved
  5. Did you know you could run ansible-test locally?
  6. What areas would you be interested in contributing to?

ansible/community#353

@gundalow gundalow added the contrib_follow_up https://github.com/ansible/community/issues/353 label Oct 27, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. contrib_follow_up https://github.com/ansible/community/issues/353 module This issue/PR relates to a module. netapp new_contributor This PR is the first contribution by a new community member. owner_pr This PR is made by the module's maintainer. storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

netapp_e_lun_mapping "Module Failure"
5 participants
@ndswartz @ansibot @gundalow @bcoca @swartzn