Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if we already have stderr, we don't need stderr_lines #44675

Merged
merged 1 commit into from
Nov 6, 2018
Merged

if we already have stderr, we don't need stderr_lines #44675

merged 1 commit into from
Nov 6, 2018

Conversation

chenzhiwei
Copy link
Contributor

SUMMARY

When using yaml callback, we already have a beauty stderr message, so I think we don't need stderr_lines anymore. And this keeps align with stdout and stdout_lines.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

yaml callback plugin

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 25, 2018
@jctanner jctanner added this to the 2.8.0 milestone Aug 25, 2018
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Aug 28, 2018
@bcoca bcoca removed this from the 2.8.0 milestone Aug 28, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 5, 2018
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 21, 2018
@ansibot ansibot added the community_review In order to be merged, this PR must follow the community review workflow. label Oct 24, 2018
@maxamillion
Copy link
Contributor

rebuild_merge

@sivel sivel mentioned this pull request Nov 6, 2018
Closed
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 6, 2018
@ssbarnea
Copy link
Member

ssbarnea commented Nov 6, 2018

Once merged, I hope to see this backported to 2.6 and 2.7.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 6, 2018
@ansibot ansibot merged commit 329d3b8 into ansible:devel Nov 6, 2018
@chenzhiwei chenzhiwei deleted the omit-stderr branch November 7, 2018 02:19
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@chenzhiwei @mjmayer
if we already have stderr, we don't need stderr_lines (ansible#44675)
0a18baa
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@chenzhiwei @Tomorrow9
if we already have stderr, we don't need stderr_lines (ansible#44675)
ce1e060
@ElijahLynn
Copy link
Contributor

ElijahLynn commented Jul 10, 2019 •
edited

Once merged, I hope to see this backported to 2.6 and 2.7.

Thanks for noting this. Was just wondering why I was seeing duplicate output for yaml stdout_callback on lines and out and see that server is still on 2.7.9! Saved me some sanity!

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@maxamillion maxamillion maxamillion approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@chenzhiwei @maxamillion @ssbarnea @ElijahLynn @ryansb @bcoca @jctanner @ansibot