Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an user facts module for Online #44709

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Add an user facts module for Online #44709

merged 1 commit into from
Aug 31, 2018

Conversation

remyleone
Copy link
Contributor

SUMMARY

Add an user facts module for Online

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • online
  • online_user_facts
ANSIBLE VERSION
$ ansible --version
ansible 2.7.0.dev0 (online_user a88758d7e7) last updated 2018/08/27 10:55:11 (GMT +200)
  config file = None
  configured module search path = [u'/Users/sieben/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/sieben/workspace/ansible/lib/ansible
  executable location = /Users/sieben/workspace/ansible/bin/ansible
  python version = 2.7.15 (default, Jun 17 2018, 12:46:58) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 27, 2018
Spredzy
Spredzy approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@Spredzy Spredzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

shipit

@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Aug 28, 2018
@remyleone
Copy link
Contributor Author

shipit

@maxamillion
Copy link
Contributor

rebuild_merge

@ansibot ansibot merged commit 5cf9644 into ansible:devel Aug 31, 2018
@remyleone remyleone deleted the online_user branch September 3, 2018 09:24
abadger pushed a commit to abadger/ansible that referenced this pull request Sep 4, 2018
@remyleone @abadger
[stable-2.7] Add an user facts module for Online (ansible#44709)
caa8984 
(cherry picked from commit 5cf9644)

Co-authored-by: Rémy Léone <remy.leone@gmail.com>
abadger pushed a commit that referenced this pull request Sep 4, 2018
@remyleone @abadger
[stable-2.7] Add an user facts module for Online (#44709)
4fff85d 
(cherry picked from commit 5cf9644)

Co-authored-by: Rémy Léone <remy.leone@gmail.com>
ndswartz pushed a commit to ndswartz/ansible that referenced this pull request Nov 28, 2018
@remyleone @swartzn
[stable-2.7] Add an user facts module for Online (ansible#44709)
8d6d8ed 
(cherry picked from commit 5cf9644)

Co-authored-by: Rémy Léone <remy.leone@gmail.com>
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger abadger left review comments

@Spredzy Spredzy Spredzy approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@remyleone @maxamillion @abadger @Spredzy @ryansb @ansibot