Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix linux web app java linux_fx_version #44715

Merged
merged 3 commits into from
Aug 28, 2018
Merged

fix linux web app java linux_fx_version #44715

merged 3 commits into from
Aug 28, 2018

Conversation

yungezz
Copy link
Contributor

@yungezz yungezz commented Aug 27, 2018

SUMMARY

FIx bug when Linux web app with java framework, linux_fx_version format is different.
eg.
if java framework with tomcat, linux_fx_version ='TOMCAT|8.5-jre8'
if java framework without container, linux_fx_version='JAVA|8-jre8'
and only supports java version 8 for linux.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ANSIBLE VERSION
ansible 2.7
ADDITIONAL INFORMATION

@yungezz yungezz requested a review from zikalino August 27, 2018 12:33
@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho @zikalino
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Aug 27, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 27, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_webapp.py:548:136: E221 multiple spaces before operator

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 27, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request Aug 28, 2018
Closed
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 28, 2018
@yungezz yungezz merged commit 661172a into ansible:devel Aug 28, 2018
@yungezz yungezz deleted the yungez-bugfixing branch August 28, 2018 05:14
zikalino pushed a commit that referenced this pull request Aug 28, 2018
Revert "fix linux web app java linux_fx_version (#44715)"
8a10f3f 
This reverts commit 661172a.
@yungezz yungezz mentioned this pull request Aug 28, 2018
Merged
@yungezz yungezz restored the yungez-bugfixing branch August 28, 2018 06:33
ganeshrn pushed a commit to ganeshrn/ansible that referenced this pull request Aug 28, 2018
@yungezz
Revert "fix linux web app java linux_fx_version (ansible#44715)" (ans…
289be02 
…ible#44750)
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Aug 28, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zikalino zikalino Awaiting requested review from zikalino

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yungezz @ansibot @webknjaz