Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error condition handling for dnf module #44770

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Improve error condition handling for dnf module #44770

merged 1 commit into from
Aug 28, 2018

Conversation

maxamillion
Copy link
Contributor

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY
  • Fix comma separated list handling for package names
  • Fix error message for unavailable/unknown package install attempt
  • Fix pkg install result output generation
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

dnf

ANSIBLE VERSION
ansible 2.7.0.a1.post0 (modules/dnf ca9e80847f) last updated 2018/08/28 09:47:15 (GMT -500)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/admiller/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/admiller/src/dev/ansible/lib/ansible
  executable location = /home/admiller/src/dev/ansible/bin/ansible
  python version = 2.7.15 (default, May 16 2018, 17:50:09) [GCC 8.1.1 20180502 (Red Hat 8.1.1-1)]

@ansibot
Copy link
Contributor

ansibot commented Aug 28, 2018

cc @DJMuggs @berenddeschouwer @ignatenkobrain
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 28, 2018
@maxamillion
Improve error condition handling for dnf module
6feb470 
- Fix comma separated list handling for package names
- Fix error message for unavailable/unknown package install attempt
- Fix pkg install result output generation

Signed-off-by: Adam Miller <admiller@redhat.com>
ignatenkobrain
ignatenkobrain approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@ignatenkobrain ignatenkobrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever :) :shipit:

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. test This PR relates to tests. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Aug 28, 2018
@maxamillion
Copy link
Contributor Author

rebuild_merge

@ansibot ansibot merged commit 1e3b927 into ansible:devel Aug 28, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ignatenkobrain ignatenkobrain ignatenkobrain approved these changes

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxamillion @ansibot @ignatenkobrain @achinthagunasekara