Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates bigip_facts #44790

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

caphrim007
Copy link
Contributor

SUMMARY

This module has been superceded by the bigip_device_facts module

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

bigip_facts

ANSIBLE VERSION
ansible 2.7.0.dev0
  config file = /here/test/integration/ansible.cfg
  configured module search path = ['/here/library/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.6 (default, Jul 17 2018, 11:12:33) [GCC 6.3.0 20170516]
ADDITIONAL INFORMATION

@caphrim007 caphrim007 force-pushed the feature.deprecate-bigip-facts branch 3 times, most recently from caff824 to cbd5336 Compare August 28, 2018 20:58
@ansibot
Copy link
Contributor

ansibot commented Aug 28, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/f5/_bigip_facts.py:0:0: missing documentation (or could not parse documentation): u'alternative'

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/f5/_bigip_facts.py:0:0: missing documentation (or could not parse documentation): u'alternative'

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/f5/_bigip_facts.py:0:0: missing documentation (or could not parse documentation): 'alternative'

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/f5/_bigip_facts.py:0:0: missing documentation (or could not parse documentation): 'alternative'

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/f5/_bigip_facts.py:0:0: missing documentation (or could not parse documentation): 'alternative'

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/network/f5/_bigip_facts.py:0:0: E103 Did not find a call to removed_module()
lib/ansible/modules/network/f5/_bigip_facts.py:0:0: E305 DOCUMENTATION.deprecated.alternative: required key not provided @ data['deprecated']['alternative']. Got None
lib/ansible/modules/network/f5/_bigip_facts.py:0:0: E305 DOCUMENTATION.deprecated.removed_in: not a valid value for dictionary value @ data['deprecated']['removed_in']. Got 2.7
lib/ansible/modules/network/f5/_bigip_facts.py:0:0: E318 Module deprecation/removed must agree in Metadata, by prepending filename with "_", and setting DOCUMENTATION.deprecated for deprecation or by removing all documentation for removed

click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. f5 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. python3 support:community This issue/PR relates to code supported by the Ansible community. labels Aug 28, 2018
@caphrim007 caphrim007 removed the needs_triage Needs a first human triage before being processed. label Aug 28, 2018
@caphrim007 caphrim007 force-pushed the feature.deprecate-bigip-facts branch from cbd5336 to e0fb0b2 Compare August 28, 2018 22:24
@ansibot
Copy link
Contributor

ansibot commented Aug 28, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/f5/_bigip_facts.py:0:0: E305 DOCUMENTATION.deprecated.removed_in: not a valid value for dictionary value @ data['deprecated']['removed_in']. Got 2.11
lib/ansible/modules/network/f5/_bigip_facts.py:0:0: E318 Module deprecation/removed must agree in Metadata, by prepending filename with "_", and setting DOCUMENTATION.deprecated for deprecation or by removing all documentation for removed

click here for bot help

@caphrim007 caphrim007 force-pushed the feature.deprecate-bigip-facts branch from e0fb0b2 to 23c87f1 Compare August 28, 2018 22:38
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Aug 28, 2018
@caphrim007 caphrim007 force-pushed the feature.deprecate-bigip-facts branch from 23c87f1 to eca726a Compare August 28, 2018 22:45
@ansibot
Copy link
Contributor

ansibot commented Aug 28, 2018

The test ansible-test sanity --test docs-build [explain] failed with 3 errors:

docs/docsite/rst/modules/bigip_facts_module.rst:5:0: warning: malformed hyperlink target.
docs/docsite/rst/modules/list_of_all_modules.rst:302:0: undefined-label: undefined label: bigip_facts_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:495:0: undefined-label: undefined label: bigip_facts_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/f5/_bigip_facts.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got '_bigip_facts'

click here for bot help

This module has been superceded by the bigip_device_facts module
@caphrim007 caphrim007 force-pushed the feature.deprecate-bigip-facts branch from eca726a to da1bafa Compare August 29, 2018 00:49
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 29, 2018
@caphrim007 caphrim007 merged commit 34b7b77 into ansible:devel Aug 29, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. f5 module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. python3 support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants