Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last minute GCP Changes #44796

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Last minute GCP Changes #44796

merged 1 commit into from
Aug 29, 2018

Conversation

rambleraptor
Copy link
Contributor

SUMMARY

  • Added two new fields (iap and load_balancing_scheme) to gcp_compute_backend_service

  • Allowed for home path expansion on gcp_utils.py auth. This allows all modules + inventory plugin to use home paths in service account file locations.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gcp_compute_backend_service

ANSIBLE VERSION
2.7

@ansibot
Copy link
Contributor

ansibot commented Aug 28, 2018

cc @erjohnso @GoogleCloudPlatform
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 28, 2018
@erjohnso
Copy link
Contributor

The fix for os.path.expanduser lgtm. I'm assuming I didn't need to review gcp_compute_backend_service so only gave it a light glance.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 29, 2018
ryansb
ryansb reviewed Aug 29, 2018
View reviewed changes
lib/ansible/module_utils/gcp_utils.py Outdated
@@ -129,8 +129,8 @@ def _credentials(self):
credentials, project_id = google.auth.default()
return credentials
elif cred_type == 'serviceaccount':
return service_account.Credentials.from_service_account_file(
self.module.params['service_account_file'])
path = os.path.expanduser(self.module.params['service_account_file'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's necessary, but adding an os.path.realpath here wouldn't hurt.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 29, 2018
@ryansb ryansb merged commit 56fa7ee into ansible:devel Aug 29, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb left review comments

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rambleraptor @ansibot @erjohnso @ryansb