Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_disk_image: return all mount paths in return value #44799

Merged
merged 1 commit into from
Aug 30, 2018
Merged

win_disk_image: return all mount paths in return value #44799

merged 1 commit into from
Aug 30, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

If a VHD(X) contains multiple partitions the return value mount_path always references the first partition. This PR deprecates mount_path and adds a new return value mount_paths which returns a list of paths. In this case a user can access both the original value with {{ res.mount_paths[0] }} and now see all the other partition mounts.

Supersedes #41101

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_disk_image

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2018

cc @acozine @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Aug 29, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Aug 30, 2018
@jborean93 jborean93 merged commit 5336566 into ansible:devel Aug 30, 2018
@jborean93 jborean93 deleted the win_disk_image-mount-paths branch August 30, 2018 06:25
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jborean93 @ansibot