Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows async: return pipeline output in case of a failure #44807

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

If an async process fails in an expectant way there may be no job output (or not a valid output) for the async watchdog to parse. To help with troubleshooting these issues this PR will return both the output and error streams from the async task which should help us identify what may have gone wrong.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

powershell.py

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Aug 29, 2018
Copy link
Contributor

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and INTN (I need this now)

@dagwieers dagwieers merged commit 5595998 into ansible:devel Aug 29, 2018
@jborean93 jborean93 deleted the win-async-error branch August 29, 2018 19:07
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Aug 30, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants