Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hashi_vault lookup: add integration tests #44814

Merged
merged 2 commits into from
Sep 13, 2018
Merged

hashi_vault lookup: add integration tests #44814

merged 2 commits into from
Sep 13, 2018

Conversation

pilou-
Copy link
Contributor

@pilou- pilou- commented Aug 29, 2018

SUMMARY

hashi_vault lookup: add integration tests

Test cases:

  • auth method: token and approle
  • with SSL, with SSL with certificate validation disabled, without SSL
  • parameters: environment variables (VAULT_*) or lookup parameters (cacert, url)
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

hashi_vault

ANSIBLE VERSION
2.7

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 29, 2018
@pilou- pilou- force-pushed the lookup_hashi_vault_add_integration_tests branch from 76fc2de to 27a419c Compare August 29, 2018 11:03
@pilou- pilou- changed the title hashi_vault lookup: add integration tests WIP: hashi_vault lookup: add integration tests Aug 29, 2018
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Aug 29, 2018
@pilou- pilou- force-pushed the lookup_hashi_vault_add_integration_tests branch 3 times, most recently from 37bec03 to ae9b51f Compare August 29, 2018 17:02
@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2018

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/lookup_hashi_vault/lookup_hashi_vault/tasks/main.yml:47:95: error syntax error: expected <block end>, but found '<scalar>'

click here for bot help

@pilou- pilou- force-pushed the lookup_hashi_vault_add_integration_tests branch from ae9b51f to 93d9471 Compare August 29, 2018 17:44
@pilou- pilou- force-pushed the lookup_hashi_vault_add_integration_tests branch from 93d9471 to 2cda431 Compare August 30, 2018 01:47
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Aug 30, 2018
@pilou- pilou- changed the title WIP: hashi_vault lookup: add integration tests hashi_vault lookup: add integration tests Aug 30, 2018
@ansibot ansibot removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 30, 2018
@pilou- pilou- mentioned this pull request Aug 30, 2018
Closed
@pilou-
Copy link
Contributor Author

pilou- commented Sep 5, 2018

@mattclay please, could you put the following files on https://ansible-ci-files.s3.amazonaws.com/test/integration/targets/lookup_hashi_vault/ ? PR has been updated with ansible-ci-files URL.

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 5, 2018
@mattclay
Copy link
Member

mattclay commented Sep 5, 2018

@pilou- The files have been uploaded and I've restarted the tests.

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 5, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 13, 2018
@gundalow gundalow merged commit 9984c0f into ansible:devel Sep 13, 2018
pilou- added a commit to pilou-/ansible that referenced this pull request Sep 14, 2018
@pilou-
hashi_vault lookup: add integration tests (ansible#44814)
2d66322 
* hashi_vault lookup: add integration tests

* hashi_vault lookup tests: use ansible-ci-files

(cherry picked from commit 9984c0f)
@pilou- pilou- mentioned this pull request Sep 14, 2018
Merged
abadger pushed a commit that referenced this pull request Sep 19, 2018
@pilou- @abadger
hashi_vault lookup: add integration tests (#44814)
92f7429 
* hashi_vault lookup: add integration tests

* hashi_vault lookup tests: use ansible-ci-files

(cherry picked from commit 9984c0f)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 feature This issue/PR relates to a feature request. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pilou- @ansibot @mattclay @gundalow @jborean93