Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete_on_termination to all EC2 root volumes #44818

Merged
merged 1 commit into from
Aug 30, 2018

Conversation

willthames
Copy link
Contributor

SUMMARY

Not terminating volumes on instance deletion causes
unwanted costs

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_instance

ANSIBLE VERSION
ansible 2.7.0.a1.post0 (devel ed2cd40a5b) last updated 2018/08/29 20:46:42 (GMT +1000)
  config file = None
  configured module search path = [u'/Users/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/will/src/ansible/lib/ansible
  executable location = /Users/will/src/ansible/bin/ansible
  python version = 2.7.14 (default, Mar  9 2018, 23:57:12) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]

Not terminating volumes on instance deletion causes
unwanted costs
@willthames willthames requested a review from ryansb August 29, 2018 10:47
@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2018

cc @ryansb
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Aug 29, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 29, 2018
@ryansb ryansb merged commit 0c22c0c into ansible:devel Aug 30, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cloud support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants