Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to enable public ip at server creation #44826

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Add an option to enable public ip at server creation #44826

merged 1 commit into from
Sep 20, 2018

Conversation

remyleone
Copy link
Contributor

SUMMARY

Add an option to enable public ip at server creation

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • scaleway_compute
ANSIBLE VERSION
ansible 2.7.0.dev0
  config file = None
  configured module search path = [u'/Users/sieben/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible-2.7.0.dev0-py2.7.egg/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15 (default, Jun 17 2018, 12:46:58) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. scaleway support:community This issue/PR relates to code supported by the Ansible community. labels Aug 29, 2018
@ansibot
Copy link
Contributor

ansibot commented Aug 29, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: E309 version_added for new option (enable_dynamic_public_ip) should be 2.7. Currently 0.0

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Aug 29, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 29, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Aug 30, 2018
@remyleone
Copy link
Contributor Author

I've implemented it in #45121 also because I need it to test IP assignation to a server

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 6, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 14, 2018
@remyleone
Copy link
Contributor Author

@pilou- this one is about adding an option. Could you review it also?

pilou-
pilou- reviewed Sep 16, 2018
View reviewed changes
lib/ansible/modules/cloud/scaleway/scaleway_compute.py Outdated
description:
- Enable a public IP at server creation
default: true
version_added: 2.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2.8 instead of 2.7

lib/ansible/modules/cloud/scaleway/scaleway_compute.py Outdated
@@ -29,6 +29,13 @@

options:

enable_dynamic_public_ip:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would rather use a public_ip parameter, which would be either:

  • an existing scaleway address ID
  • allocate (or dynamic): in this case, IP is destroyed at the same time the host is destroyed
  • absent: no public IP at all

See https://github.com/ansible/ansible/pull/45121/files#r217889653

@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: E305 DOCUMENTATION.options.public_ip.description.2: expected str @ data['options']['public_ip']['description'][2]. Got {'dynamic': 'in this case, IP is destroyed at the same time the host is destroyed'}
lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: E305 DOCUMENTATION.options.public_ip.description.3: expected str @ data['options']['public_ip']['description'][3]. Got {'absent': 'no public IP at all'}
lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: E324 Value for "default" from the argument_spec ('True') for "public_ip" does not match the documentation (None)

click here for bot help

@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Sep 19, 2018
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 19, 2018
@remyleone remyleone changed the title Add an option to enable public ip at server creation WIP: Add an option to enable public ip at server creation Sep 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: E305 DOCUMENTATION.options.public_ip.description.2: expected str @ data['options']['public_ip']['description'][2]. Got {'dynamic': 'in this case, IP is destroyed at the same time the host is destroyed'}
lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: E305 DOCUMENTATION.options.public_ip.description.3: expected str @ data['options']['public_ip']['description'][3]. Got {'absent': 'no public IP at all'}
lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: E324 Value for "default" from the argument_spec ('True') for "public_ip" does not match the documentation ('absent')

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. test This PR relates to tests. labels Sep 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2018

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: E305 DOCUMENTATION.options.public_ip.description.2: expected str @ data['options']['public_ip']['description'][2]. Got {'dynamic': 'in this case, IP is destroyed at the same time the host is destroyed'}
lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: E305 DOCUMENTATION.options.public_ip.description.3: expected str @ data['options']['public_ip']['description'][3]. Got {'absent': 'no public IP at all'}
lib/ansible/modules/cloud/scaleway/scaleway_compute.py:0:0: E324 Value for "default" from the argument_spec ('True') for "public_ip" does not match the documentation ('absent')

click here for bot help

@remyleone remyleone force-pushed the public_ip_option branch 2 times, most recently from 4ada5e3 to ba85b21 Compare September 20, 2018 11:38
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 20, 2018
@remyleone
Copy link
Contributor Author

@g1franc @pilou- could you review?

@remyleone remyleone changed the title WIP: Add an option to enable public ip at server creation Add an option to enable public ip at server creation Sep 20, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 20, 2018
@maxamillion
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 20, 2018
@maxamillion
Copy link
Contributor

rebuild_merge

@ansibot ansibot merged commit 7c7a7ef into ansible:devel Sep 20, 2018
@remyleone remyleone deleted the public_ip_option branch September 20, 2018 16:22
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pilou- pilou- pilou- left review comments

@maxamillion maxamillion maxamillion approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. scaleway shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@remyleone @ansibot @maxamillion @pilou- @jborean93