Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Improve documentation style and readability. #44876

Merged
merged 1 commit into from
Aug 30, 2018
Merged

helm: Improve documentation style and readability. #44876

merged 1 commit into from
Aug 30, 2018

Conversation

geerlingguy
Copy link
Contributor

@geerlingguy geerlingguy commented Aug 30, 2018

SUMMARY

Improve documentation style and readability.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

helm

ANSIBLE VERSION
ansible 2.6.3
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/Users/jgeerling/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15 (default, Jul 17 2018, 19:41:20) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]
ADDITIONAL INFORMATION

N/A

@ansibot
Copy link
Contributor

ansibot commented Aug 30, 2018

@geerlingguy Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 30, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 cloud docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. community_review In order to be merged, this PR must follow the community review workflow. and removed needs_info This issue requires further information. Please answer any outstanding questions. needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly. labels Aug 30, 2018
@geerlingguy
Copy link
Contributor Author

Updated the initial message to fit the template (editor for hub pull-request dropped the headings as comments, d'oh!)

@acozine acozine removed the needs_triage Needs a first human triage before being processed. label Aug 30, 2018
@acozine
Copy link
Contributor

acozine commented Aug 30, 2018

Thanks @geerlingguy for fixing the typo and adding the readability fixes.

@acozine acozine merged commit c3e526b into ansible:devel Aug 30, 2018
@dagwieers dagwieers added the k8s label Feb 8, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. k8s module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants