azure vm test: async second vm deletion #44887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattclay
approved these changes
Aug 30, 2018
ansibot
added
affects_2.7
ansibot
added
the
needs_revision
ansibot
removed
the
needs_revision
zikalino
reviewed
Aug 31, 2018
| host: '{{ hostvars["new_azure_vm"].ansible_host }}' | ||
| port: 22 | ||
| timeout: 60 | ||
| state: started |
There was a problem hiding this comment.
they're used for below commented out test, after 22 port ready, install something on the vm, but below tests are commented out already, so this waifor is meaningless.
There was a problem hiding this comment.
yes, seems like the commented out test is very unstable.... so just wanted to confirm if you found similar issue :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
there're 2 vm deletion in azure vm test. second one has no assertion. to reduce test execution time, make second deletion async, since we don't care about deletion result.
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION