Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iosxr cli_config module diff issue #44898

Merged
merged 2 commits into from
Aug 30, 2018
Merged

Fix iosxr cli_config module diff issue #44898

merged 2 commits into from
Aug 30, 2018

Conversation

ganeshrn
Copy link
Member

SUMMARY
  • Modify iosxr plugin to support configuration
    diff capability (get_diff()) within Ansible
    to be in sync with iosxr_config module.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iosxr_config
module_utils/network/iosxr/iosxr.py
ansible/modules/network/iosxr/iosxr_config.py

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

@ganeshrn
Fix iosxr cli_config module diff issue
f538882 
* Modify iosxr plugin to support configuration
  diff capability (get_diff()) within Ansible
  to be in sync with iosxr_config module.
@ansibot
Copy link
Contributor

ansibot commented Aug 30, 2018

cc @Qalthos @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Aug 30, 2018
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Aug 30, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 30, 2018
@gundalow
Copy link
Contributor

Unit tests failing on Py2.6

@ansibot ansibot added test This PR relates to tests. core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 30, 2018
@ganeshrn ganeshrn merged commit 1a684df into ansible:devel Aug 30, 2018
@ganeshrn ganeshrn deleted the test branch August 30, 2018 16:09
@dagwieers dagwieers added iosxr Cisco IOSXR community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdpak gdpak gdpak approved these changes

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. iosxr Cisco IOSXR community module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ganeshrn @ansibot @gundalow @gdpak @trishnaguha @dagwieers