Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we only cache the loop when the task had a loop #44901

Merged
merged 2 commits into from
Aug 30, 2018
Merged

Ensure we only cache the loop when the task had a loop #44901

merged 2 commits into from
Aug 30, 2018

Conversation

sivel
Copy link
Member

@sivel sivel commented Aug 30, 2018

SUMMARY

Ensure we only cache the loop when the task had a loop. Fixes #44874

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/vars/manager.py

ANSIBLE VERSION
2.7
ADDITIONAL INFORMATION

@sivel sivel mentioned this pull request Aug 30, 2018
Closed
@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Aug 30, 2018
jladdjr
jladdjr approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@jladdjr jladdjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ran Tower's cluster installer with this change. Confirmed installation was successful. Thanks for the quick fix!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Aug 30, 2018
@sivel sivel merged commit 9d89e15 into ansible:devel Aug 30, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jladdjr jladdjr jladdjr approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task result not saved when delegate_to points to set_stat var
3 participants
@sivel @jladdjr @ansibot