Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pure Storage FlashBlade module to manage directory service roles #44926

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Add Pure Storage FlashBlade module to manage directory service roles #44926

merged 1 commit into from
Oct 30, 2018

Conversation

sdodsley
Copy link
Contributor

SUMMARY

Add a new module to configure the directory services roles on a Pure Storage FlashBlade.
Supported roles are:

  • array_admin
  • ops_admin
  • readonly
  • storage_admin
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

modules/storage/purestorage/purefb_dsrole

ANSIBLE VERSION
ansible 2.7.0.dev0
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible-2.7.0.dev0-py2.7.egg/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. storage support:community This issue/PR relates to code supported by the Ansible community. labels Aug 30, 2018
@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 30, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 5, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 13, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 28, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 28, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/storage/purestorage/purefb_dsrole.py:0:0: E307 version_added should be 2.8. Currently 2.7

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 28, 2018
@sdodsley sdodsley changed the title Add Pure Storage FlashBlade module to manage direcotry service roles Add Pure Storage FlashBlade module to manage directory service roles Sep 28, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 28, 2018
@ansibot ansibot added pure_storage stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 6, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 8, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2018

@genegr @lionmax @sile16

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2018

cc @genegr @lionmax @sile16
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2018

cc @bannaych @raekins
click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 16, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 18, 2018
@sdodsley sdodsley force-pushed the purefb_dsrole branch 2 times, most recently from 47edec3 to eea3b8d Compare October 24, 2018 21:54
@sile16
Copy link

sile16 commented Oct 24, 2018

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 24, 2018
@gundalow gundalow merged commit 73964a9 into ansible:devel Oct 30, 2018
@sdodsley sdodsley deleted the purefb_dsrole branch October 30, 2018 13:32
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@sdodsley @Tomorrow9
Add Pure Storage FlashBlade module to manage direcotry service roles (a…
706551a 
…nsible#44926)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sile16 sile16 sile16 approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. pure_storage shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sdodsley @ansibot @sile16 @bcoca @gundalow