Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebrew_cask: Pass install_options during uninstall #44938

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

newtonne
Copy link
Contributor

SUMMARY

Until Homebrew/homebrew-cask#40866 is fixed,
install_options should be passed when uninstalling casks to ensure that
all artefacts are removed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

homebrew_cask

ANSIBLE VERSION
ansible 2.7.0.a1.post0 (devel ac3781d40b) last updated 2018/08/31 00:53:49 (GMT +100)
  config file = None
  configured module search path = ['/Users/newtonne/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/newtonne/Projects/contrib/ansible/lib/ansible
  executable location = /Users/newtonne/Projects/contrib/ansible/bin/ansible
  python version = 3.6.6 (default, Jun 28 2018, 05:43:53) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

Until Homebrew/homebrew-cask#40866 is fixed,
install_options should be passed when uninstalling casks to ensure that
all artefacts are removed.
@ansibot
Copy link
Contributor

ansibot commented Aug 31, 2018

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Aug 31, 2018
@newtonne
Copy link
Contributor Author

ready_for_review

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Aug 31, 2018
@danieljaouen
Copy link
Contributor

LGTM

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 10, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 18, 2018
@mscherer
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2018

Components

lib/ansible/modules/packaging/os/homebrew_cask.py
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 1
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): danieljaouen
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@mscherer
Copy link
Contributor

So, the bot should have merged that , we are looking at that, cause it should be listed as core.

@gundalow gundalow merged commit aac1ce7 into ansible:devel Sep 25, 2018
@dagwieers dagwieers added the macos macOS community label Jan 23, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. macos macOS community module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants