Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpm_user concat string changes #45044

Merged
merged 6 commits into from
Nov 9, 2018
Merged

cpm_user concat string changes #45044

merged 6 commits into from
Nov 9, 2018

Conversation

syncpak
Copy link
Contributor

@syncpak syncpak commented Sep 1, 2018

SUMMARY

change the way the strings are concatenated

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cpm_user

ANSIBLE VERSION
ansible 2.8.0.dev0 (cpm_user_mod 048c517045) last updated 2018/08/31 17:10:27 (GMT -700)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/kenp/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/kenp/ansible/lib/ansible
  executable location = /home/kenp/ansible/bin/ansible
  python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]
ADDITIONAL INFORMATION

Changed str() to to_native()
Changed + string concat to %

@ansibot
Copy link
Contributor

ansibot commented Sep 1, 2018

cc @wtinetworkgear
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 1, 2018
@syncpak syncpak mentioned this pull request Sep 1, 2018
Merged
samdoran
samdoran suggested changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several other text strings that also need to_native(), such as user_password and user_callbackphone.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Sep 4, 2018
@syncpak
Copy link
Contributor Author

syncpak commented Sep 4, 2018

@samdoran we added what we believe to_native() to all the places that incorporate external values into strings. Thanks

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 7, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 15, 2018
@ansibot ansibot removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 9, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) support:community This issue/PR relates to code supported by the Ansible community. labels Oct 9, 2018
@samdoran
Copy link
Contributor

samdoran commented Nov 9, 2018

rebuild_merge

@ansibot ansibot removed needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 9, 2018
@ansibot ansibot merged commit 301defd into ansible:devel Nov 9, 2018
Ghilli3 pushed a commit to Ghilli3/ansible that referenced this pull request Nov 12, 2018
@syncpak @Ghilli3
cpm_user concat string changes (ansible#45044)
fa77865 
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* remove unneeded legacy files

* Changed str() to to_native()
Changed + string concat to %

* added to_native() to the remainder of strings being read externally
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@syncpak @mjmayer
cpm_user concat string changes (ansible#45044)
b154dcc 
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* remove unneeded legacy files

* Changed str() to to_native()
Changed + string concat to %

* added to_native() to the remainder of strings being read externally
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@syncpak @Tomorrow9
cpm_user concat string changes (ansible#45044)
7a337a6 
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* remove unneeded legacy files

* Changed str() to to_native()
Changed + string concat to %

* added to_native() to the remainder of strings being read externally
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
@syncpak syncpak deleted the cpm_user_mod branch November 1, 2019 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

@samdoran samdoran samdoran approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@syncpak @ansibot @samdoran @achinthagunasekara @wtinetworkgear