Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding sql firewall rule facts #45059

Merged
merged 12 commits into from
Sep 13, 2018
Merged

adding sql firewall rule facts #45059

merged 12 commits into from
Sep 13, 2018

Conversation

zikalino
Copy link
Contributor

@zikalino zikalino commented Sep 1, 2018

SUMMARY

Adding SQL Firewall Rule facts module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_sqlfirewallrule_facts

ANSIBLE VERSION

2.7

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 1, 2018

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/azure_rm_sqlfirewallrule_facts/aliases:0:0: missing alias `shippable/azure/group[1-8]` or `unsupported`

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlfirewallrule_facts.py:200:1: E305 expected 2 blank lines after class or function definition, found 0

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/cloud/azure/azure_rm_sqlfirewallrule_facts.py:0:0: E307 version_added should be 2.8. Currently 2.5
lib/ansible/modules/cloud/azure/azure_rm_sqlfirewallrule_facts.py:0:0: E322 "append_tags" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_sqlfirewallrule_facts.py:0:0: E322 "tags" is listed in the argument_spec, but not documented in the module
lib/ansible/modules/cloud/azure/azure_rm_sqlfirewallrule_facts.py:0:0: E324 Value for "default" from the argument_spec (True) for "append_tags" does not match the documentation (False)
lib/ansible/modules/cloud/azure/azure_rm_sqlfirewallrule_facts.py:0:0: E325 argument_spec for "append_tags" defines type="bool" but documentation does not

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 1, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.7 This issue/PR affects Ansible v2.7 azure ci_verified Changes made in this PR are causing tests to fail. cloud module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Sep 1, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request Sep 2, 2018
Closed
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 9, 2018
@zikalino zikalino changed the title [WIP] adding sql firewall rule facts adding sql firewall rule facts Sep 9, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 9, 2018

@Madhura-CSI @brusMX @devigned @gustavomcarmo @haroldwongms @julienstroheker @lmazuel @obsoleted @sozercan @tripdubroot @trstringer @tstringer @xscript @yaweiw @yuwzho

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Sep 9, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 12, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_sqlfirewallrule_facts.py:204:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 12, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 12, 2018
yungezz
yungezz reviewed Sep 13, 2018
View reviewed changes
lib/ansible/modules/cloud/azure/azure_rm_sqlfirewallrule_facts.py Outdated
---
module: azure_rm_sqlfirewallrule_facts
version_added: "2.8"
short_description: Get SQL Firewall Rule facts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

yungezz
yungezz reviewed Sep 13, 2018
View reviewed changes
lib/ansible/modules/cloud/azure/azure_rm_sqlfirewallrule_facts.py Outdated
options:
resource_group:
description:
- The name of the resource group that contains the resource. You can obtain this value from the Azure Resource Manager API or the portal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the "You can obtain...." sentence is not necessary, but it's minor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

yungezz
yungezz reviewed Sep 13, 2018
View reviewed changes
lib/ansible/modules/cloud/azure/azure_rm_sqlfirewallrule_facts.py Outdated
resource_group:
description:
- The name of the resource group that contains the resource. You can obtain this value from the Azure Resource Manager API or the portal.
required: True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resoruce group requried?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

yungezz
yungezz reviewed Sep 13, 2018
View reviewed changes
lib/ansible/modules/cloud/azure/azure_rm_sqlfirewallrule_facts.py
description:
- The name of the server.
required: True
name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not support tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, firewall rule is subresource that doesn't have own tags

@yungezz yungezz merged commit df76891 into ansible:devel Sep 13, 2018
@yungezz yungezz deleted the facts-sqlfirewallrule branch September 13, 2018 09:55
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yungezz yungezz yungezz approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 azure cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zikalino @ansibot @yungezz @jborean93