Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aci_switch_policy_vpc_protection_group: Fix idempotency #45091

Merged
merged 1 commit into from
Sep 3, 2018
Merged

aci_switch_policy_vpc_protection_group: Fix idempotency #45091

merged 1 commit into from
Sep 3, 2018

Conversation

dagwieers
Copy link
Contributor

SUMMARY

This fixes #43412

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aci_switch_policy_vpc_protection_group

ANSIBLE VERSION

v2.8 and earlier

@dagwieers dagwieers mentioned this pull request Sep 3, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Sep 3, 2018

cc @Qalthos @brunocalogero @ganeshrn @gdpak @jmcgill298 @justjais @rcarrillocruz @schunduri @trishnaguha
click here for bot help

@ansibot ansibot added aci Cisco ACI community affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Sep 3, 2018
@dagwieers
Copy link
Contributor Author

@jmcgill298 I would appreciate if you could review this change.

@dagwieers
Copy link
Contributor Author

@achinthagunasekara You approved 5 of my PRs in under a minute today, and you have been doing similar activity for at least a few months. Can you please stop approving PRs you did not review yourself ?

@smnmtzgr
Copy link
Contributor

smnmtzgr commented Sep 3, 2018

I have tested the changes and it seems to work correctly now. I opened the here referenced issue #43412

@dagwieers dagwieers merged commit 6faf400 into ansible:devel Sep 3, 2018
@dagwieers
Copy link
Contributor Author

@smnmtzgr Thanks for testing !

@dagwieers dagwieers mentioned this pull request Sep 3, 2018
Merged
@webknjaz webknjaz removed backport This PR does not target the devel branch. needs_triage Needs a first human triage before being processed. labels Sep 4, 2018
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achinthagunasekara achinthagunasekara achinthagunasekara approved these changes

Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.7 This issue/PR affects Ansible v2.7 bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category small_patch support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aci_switch_policy_vpc_protection_group reports "changed" everytime it runs
5 participants
@dagwieers @ansibot @smnmtzgr @achinthagunasekara @webknjaz