Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBM_Storage: Added a module to define volume mapping on IBM spectrum … #45110

Merged
merged 3 commits into from
Oct 29, 2018
Merged

IBM_Storage: Added a module to define volume mapping on IBM spectrum … #45110

merged 3 commits into from
Oct 29, 2018

Conversation

tzurE
Copy link
Contributor

@tzurE tzurE commented Sep 3, 2018

…Accelerate

storage systems.

SUMMARY

Adding a new module to the IBM storage modules. This module adds or removes volume mapping to hosts on the IBM Spectrum accelerate storage array

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ibm_sa_vol_map

ANSIBLE VERSION
ansible 2.8.0.dev0 (add_ibm_storage_vol_mapping_module 1eb5a95f80) last updated 2018/09/03 14:30:33 (GMT +300)
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 3, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/storage/ibm/ibm_sa_vol_map.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/storage/ibm/ibm_sa_vol_map.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/storage/ibm/ibm_sa_vol_map.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/storage/ibm/ibm_sa_vol_map.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/storage/ibm/ibm_sa_vol_map.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 100, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/storage/ibm/ibm_sa_vol_map.py:0:0: E324 Value for "default" from the argument_spec ('present') for "state" does not match the documentation (None)
lib/ansible/modules/storage/ibm/ibm_sa_vol_map.py:0:0: E326 Value for "choices" from the argument_spec (['present', 'absent']) for "state" does not match the documentation ([])
lib/ansible/modules/storage/ibm/ibm_sa_vol_map.py:37:9: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/storage/ibm/ibm_sa_vol_map.py:37:9: error DOCUMENTATION: syntax error: could not find expected ':'

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community. labels Sep 3, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 3, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 14, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 18, 2018
samdoran
samdoran suggested changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For new modules that we cannot test, we like to have a few community members weigh in and state the module works as intended.

lib/ansible/modules/storage/ibm/ibm_sa_vol_map.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 18, 2018
@ansibot ansibot added new_contributor This PR is the first contribution by a new community member. and removed new_contributor This PR is the first contribution by a new community member. labels Oct 22, 2018
@tzurE
Copy link
Contributor Author

tzurE commented Oct 24, 2018

@samdoran - Hi, I fixed and commented on all of the issues :)

@samdoran samdoran merged commit 524c519 into ansible:devel Oct 29, 2018
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@tzurE @Tomorrow9
IBM_Storage: Added a module to define volume mapping on IBM spectrum … (
657e9f5 
ansible#45110)

* IBM_Storage: Added a module to define volume mapping on IBM spectrum Accelerate
storage systems.

* docs fix

* IBM_storage: review and pep8 fixes
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tzurE @ansibot @samdoran