Add a Scaleway IP module #45121

remyleone · 2018-09-03T15:16:21Z

SUMMARY

This PR adds a management module for Scaleway reserved IP.

Here is the list of targeted features:

Create a new reserved IP address
Attach an ip address to a server
Update an IP address mapping (move)
Remove an IP address

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

scaleway_ip

ANSIBLE VERSION

ansible 2.8.0.dev0 (scaleway_ip 7f0f872b2b) last updated 2018/09/03 17:14:39 (GMT +200)
  config file = None
  configured module search path = [u'/Users/sieben/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/sieben/workspace/ansible/lib/ansible
  executable location = /Users/sieben/workspace/ansible/bin/ansible
  python version = 2.7.15 (default, Jun 17 2018, 12:46:58) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

remyleone · 2018-09-03T15:17:42Z

@g1franc I started working on your dynamic IP management module. I will let you know once it is ready for review.

ansibot · 2018-09-03T15:23:57Z

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

lib/ansible/modules/cloud/scaleway/scaleway_ip.py:106:18: undefined-variable Undefined variable 'volumes_json'
lib/ansible/modules/cloud/scaleway/scaleway_ip.py:114:71: undefined-variable Undefined variable 'size'
lib/ansible/modules/cloud/scaleway/scaleway_ip.py:114:92: undefined-variable Undefined variable 'volume_type'

click here for bot help

ansibot · 2018-09-04T14:35:19Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_ip.py:0:0: E322 "organization" is listed in the argument_spec, but not documented in the module

click here for bot help

ansibot · 2018-09-05T09:38:05Z

cc @Spredzy @hekonsek
click here for bot help

ansibot · 2018-09-05T09:53:59Z

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_ip.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_ip.py:0:0: missing documentation (or could not parse documentation): expected string or buffer

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_ip.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_ip.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_ip.py:0:0: missing documentation (or could not parse documentation): expected string or bytes-like object

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_ip.py:158:33: SyntaxError: ip_lookup = {ip["id"]: ip for ip in ips_list}

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_ip.py:158:33: SyntaxError: invalid syntax

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_ip.py:0:0: E305 DOCUMENTATION.options.server.description.1: expected str @ data['options']['server']['description'][1]. Got {'To unattach an IP': "don't specify this option"}

click here for bot help

g1franc · 2018-09-07T15:50:14Z

Tested and working

remyleone · 2018-09-11T07:25:24Z

@Spredzy @maxamillion Could you merge it?

ansibot · 2018-09-15T16:54:35Z

cc @mattclay
click here for bot help

pilou- · 2018-09-15T16:49:57Z

lib/ansible/modules/cloud/scaleway/scaleway_compute.py

@@ -29,6 +29,13 @@

 options:

+  dynamic_ip_required:
+    description:
+    - Enable a public IP at server creation


I propose to use:

an hardcoded IP, for example: 163.172.152.10 (or scaleway address ID?) (IP must exist and be available in the pool of reserved IPs)

attached (create an IP which will be destroyed when the node will be destroyed)

absent (don't use any public IP)

I also think this would be advantageous.

Started working on it there: https://github.com/ansible/ansible/pull/44826/files

Could you review and merge it?

pilou- · 2018-09-15T16:51:07Z

lib/ansible/modules/cloud/scaleway/scaleway_ip.py

+    description:
+    - id of the IP
+
+  server:


Should not that be handled by the scaleway_compute module ?

lib/ansible/modules/cloud/scaleway/scaleway_ip.py

pilou- · 2018-09-15T17:09:37Z

lib/ansible/modules/cloud/scaleway/scaleway_ip.py

+    argument_spec.update(dict(
+        state=dict(default='present', choices=['absent', 'present']),
+        organization=dict(),
+        server=dict(),


I would let the scaleway_compute handles IP assignation to server.

pilou- · 2018-09-15T17:22:08Z

lib/ansible/modules/cloud/scaleway/scaleway_ip.py

+
+  id:
+    description:
+    - id of the IP


It doesn't make sense to use id parameter with state=present. Currently when state=present is used and id is specified, a new IP with another id is created.

lib/ansible/modules/cloud/scaleway/scaleway_ip.py

pilou- · 2018-09-20T23:47:15Z

@sieben a rebase is required for this one

ansibot · 2018-09-20T23:52:12Z

cc @abarbare @Anthony25
click here for bot help

remyleone · 2018-09-21T08:39:47Z

Rebase done. I'm going to add additional tests for assigning ip to scaleway_compute

ansibot · 2018-09-21T08:54:01Z

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_compute.py:287:5: E303 too many blank lines (2)

click here for bot help

- Add an option to enable public ip at server creation

maxamillion · 2018-09-24T13:49:14Z

rebuild_merge

pilou- · 2018-09-25T00:05:20Z

lib/ansible/modules/cloud/scaleway/scaleway_ip.py

+    description:
+    - id of the Scaleway IP (UUID)
+
+  server:


Didn't we agree that:

this module should not handle that

scaleway_compute should be used instead
?

Indeed but I guess we can fix it in another PR.

remyleone force-pushed the scaleway_ip branch 2 times, most recently from 5625678 to 6834ee1 Compare September 4, 2018 13:56

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 4, 2018

remyleone force-pushed the scaleway_ip branch 2 times, most recently from 5e2f654 to ac52b03 Compare September 4, 2018 14:23

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 4, 2018

remyleone force-pushed the scaleway_ip branch from ac52b03 to 2a1e798 Compare September 4, 2018 14:39

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 4, 2018

remyleone force-pushed the scaleway_ip branch from 2a1e798 to 21e3d73 Compare September 5, 2018 09:35

ansibot added the inventory Inventory category label Sep 5, 2018

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 5, 2018

remyleone force-pushed the scaleway_ip branch from 21e3d73 to 9bd3288 Compare September 5, 2018 16:31

ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 5, 2018

bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2018

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 15, 2018

pilou- reviewed Sep 15, 2018

View reviewed changes

remyleone force-pushed the scaleway_ip branch 2 times, most recently from 56fb225 to f21ffde Compare September 16, 2018 12:36

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 16, 2018

pilou- mentioned this pull request Sep 20, 2018

Add test cases for scaleway_user_data #45340

Closed

remyleone force-pushed the scaleway_ip branch from f21ffde to e73db82 Compare September 21, 2018 08:37

ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Sep 21, 2018

ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Sep 21, 2018

Add a Scaleway IP module

2373ab1

- Add an option to enable public ip at server creation

remyleone force-pushed the scaleway_ip branch from e73db82 to 2373ab1 Compare September 21, 2018 08:59

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 21, 2018

ansibot merged commit 6d7004f into ansible:devel Sep 24, 2018

pilou- reviewed Sep 25, 2018

View reviewed changes

remyleone mentioned this pull request Sep 28, 2018

Fix scaleway_compute dynamic_ip_required #46256

Merged

ansible locked and limited conversation to collaborators Jul 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a Scaleway IP module #45121

Add a Scaleway IP module #45121

remyleone commented Sep 3, 2018 •

edited

remyleone commented Sep 3, 2018

ansibot commented Sep 3, 2018

ansibot commented Sep 4, 2018

ansibot commented Sep 5, 2018

ansibot commented Sep 5, 2018

g1franc commented Sep 7, 2018

remyleone commented Sep 11, 2018

ansibot commented Sep 15, 2018

pilou- Sep 15, 2018

maxamillion Sep 17, 2018

remyleone Sep 20, 2018

pilou- Sep 15, 2018

pilou- Sep 15, 2018

pilou- Sep 15, 2018

pilou- commented Sep 20, 2018

ansibot commented Sep 20, 2018

remyleone commented Sep 21, 2018

ansibot commented Sep 21, 2018

maxamillion commented Sep 24, 2018

pilou- Sep 25, 2018

remyleone Sep 25, 2018 •

edited

Add a Scaleway IP module #45121

Add a Scaleway IP module #45121

Conversation

remyleone commented Sep 3, 2018 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

remyleone commented Sep 3, 2018

ansibot commented Sep 3, 2018

ansibot commented Sep 4, 2018

ansibot commented Sep 5, 2018

ansibot commented Sep 5, 2018

g1franc commented Sep 7, 2018

remyleone commented Sep 11, 2018

ansibot commented Sep 15, 2018

pilou- Sep 15, 2018

Choose a reason for hiding this comment

maxamillion Sep 17, 2018

Choose a reason for hiding this comment

remyleone Sep 20, 2018

Choose a reason for hiding this comment

pilou- Sep 15, 2018

Choose a reason for hiding this comment

pilou- Sep 15, 2018

Choose a reason for hiding this comment

pilou- Sep 15, 2018

Choose a reason for hiding this comment

pilou- commented Sep 20, 2018

ansibot commented Sep 20, 2018

remyleone commented Sep 21, 2018

ansibot commented Sep 21, 2018

maxamillion commented Sep 24, 2018

pilou- Sep 25, 2018

Choose a reason for hiding this comment

remyleone Sep 25, 2018 • edited

Choose a reason for hiding this comment

remyleone commented Sep 3, 2018 •

edited

remyleone Sep 25, 2018 •

edited