Fix timeout detection in vmware_deploy_ovf module

[albers]

SUMMARY

Timeout detection in wait_for_vm_ip is broken. A timeout should be communicated to its caller by returning an empty dict (see vmware_deploy_ovf). But the function always returns the fully populated facts, regardless of the timeout condition.

With this PR, the facts are only returned if no timeout occurred.

Notes:

• The wait_for_vm_ip function was added in New module vmware_deploy_ovf #30309 with the introduction of vmware_deploy_ovf, which seems to be the only caller so far.
• I never actually ran into this error condition using the vmware_deploy_ovf module, probably because the preceding call to wait_for_task returns late enough so that the ip address is available anyway.
  But the bug might hit other callers, so it should be fixed.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

module_utils.vmware

ANSIBLE VERSION

  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/user/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/user/eclipse/workspaces/liclipse/ansible/lib/ansible
  executable location = /home/user/eclipse/workspaces/liclipse/ansible/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]

ADDITIONAL INFORMATION

To force the bug, uncomment wait_for_task, use a short timeout in wait_for_vm_ip and import a template with the wait_for_ip_address=true option. This will trigger the timeout condition. The module should fail.
Instead the module returns with "ipv4": null but does not fail.

[ansibot]

cc @Akasurde @dav1x @warthog9
click here for bot help

[Akasurde]

@albers Thanks for the contribution.