Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pure Storage FlashArray volume module #45225

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Update Pure Storage FlashArray volume module #45225

merged 1 commit into from
Nov 10, 2018

Conversation

sdodsley
Copy link
Contributor

@sdodsley sdodsley commented Sep 5, 2018 •
edited

SUMMARY

Update Pure Storage FlashArray module for support volume QoS with new bandwidth parameter.
Also, fix an issue when trying to delete a volume that is already deleted but not eradicated.
The correct process should be to check if a volume requested to be deleted or eradicated is already deleted before try the delete/eradicate. If already deleted then eradicate (if requested).

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

modules/storage/purestorage/purefa_volume

ANSIBLE VERSION
ansible 2.7.0.dev0
  config file = None
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible-2.7.0.dev0-py2.7.egg/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]

ADDITIONAL INFORMATION

  • Remove checking for purestorage module - there is nothing in this module which needs to bring in more from the purestorage module. What is needed is included in the core modules_utils file
  • Remove support for check_mode. This was added incorrectly when the module was first written (and I didn't understand what it really was)

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. storage support:community This issue/PR relates to code supported by the Ansible community. labels Sep 5, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2018
@sdodsley sdodsley changed the title Update Pure Storage FlashArray volume module [WIP] Update Pure Storage FlashArray volume module Sep 10, 2018
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Sep 10, 2018
@sdodsley sdodsley changed the title [WIP] Update Pure Storage FlashArray volume module Update Pure Storage FlashArray volume module Sep 11, 2018
@sdodsley sdodsley force-pushed the purefa_vol_fix branch 2 times, most recently from 91be8f6 to b0cb0c5 Compare September 11, 2018 19:41
@ansibot ansibot removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Sep 11, 2018
@mscherer
Copy link
Contributor

Mhh, that change do lot more than what the commit message say:

  • cleanup of verification of purestorage (not sure why, I guess because this is done by the module)
  • removal of check_mode

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 16, 2018
@sdodsley
Copy link
Contributor Author

@mscherer True. I have updated the commit message with more information

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 24, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 28, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. pure_storage stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 6, 2018
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Oct 6, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 8, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2018

cc @genegr @lionmax @sile16
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Oct 16, 2018

cc @bannaych @raekins
click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 17, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 18, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 26, 2018
@genegr
Copy link

genegr commented Nov 10, 2018

+label shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 10, 2018
@ansibot ansibot merged commit d508d58 into ansible:devel Nov 10, 2018
Ghilli3 pushed a commit to Ghilli3/ansible that referenced this pull request Nov 12, 2018
@sdodsley @Ghilli3
Update Pure Storage FlashArray volume module (ansible#45225)
303f1a1
@sdodsley sdodsley deleted the purefa_vol_fix branch November 26, 2018 19:32
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@sdodsley @mjmayer
Update Pure Storage FlashArray volume module (ansible#45225)
2da1b31
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@sdodsley @Tomorrow9
Update Pure Storage FlashArray volume module (ansible#45225)
edbc361
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. pure_storage shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sdodsley @mscherer @ansibot @genegr @jborean93