network command modules cleanup

[Qalthos]

SUMMARY

This started as a cleanup to some useless code in ios_command, that then bled over to other command modules.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ANSIBLE VERSION

2.8

[ansibot]

cc @beardymcbeards @ganeshrn @gdpak @justjais @mikewiebe @privateip @Qalthos @rahushen @rcarrillocruz @samdoran @trishnaguha @tstoner
click here for bot help

[ganeshrn]

Can the logic of creating ComplexList object moved to a common location with the updated spec. This change can add support for multiple prompts and multiple answers for platform-specific command modules without any code change in the module (doc might be required to be updated)

    transform = ComplexList(dict(
        command=dict(key=True),
        prompt=dict(type='list'),
        answer=dict(type='list'),
        sendonly=dict(type='bool', default=False),
        check_all=dict(type='bool', default=False),
    ), module)
    commands = transform(module.params['commands'])

[Qalthos]

Yeah, this could probably be centralized. The thing I'm not sure about is that only some of the modules want output as a key and I'm not sure if including that will introduce problems.

It seems like it shouldn't be a problem; I don't think it should create unnecessary keys, but I'll have to look into it.

[mattclay]

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/82624/4/tests

The network integration tests are also failing with a traceback:

https://app.shippable.com/github/ansible/ansible/runs/82624/29/console

[mattclay]

CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/83629/29/console

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/network/iosxr/iosxr_command.py:173:29: undefined-variable Undefined variable 'to_text'

click here for bot help