Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the root URI to match the DMTF specification #45295

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Update the root URI to match the DMTF specification #45295

merged 1 commit into from
Sep 11, 2018

Conversation

jose-delarosa
Copy link
Contributor

SUMMARY

Very small update to root_uri variable so its definition matches the DMTF specification

ISSUE TYPE
  • Bugfix Pull Request
    (Not really a bug, just a small enhancement to be compliant)
COMPONENT NAME

redfish_facts

ANSIBLE VERSION
ansible 2.7.0b1 (detached HEAD 097aaeb733) last updated 2018/09/06 10:22:42 (GMT -500)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /share1/git/ansible/lib/ansible
  executable location = /share1/git/ansible/bin/ansible
  python version = 2.7.5 (default, May 31 2018, 09:41:32) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Sep 6, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Sep 6, 2018
@ansibot ansibot added owner_pr This PR is made by the module's maintainer. and removed needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) labels Sep 6, 2018
@jose-delarosa
Copy link
Contributor Author

@jborean93 I submitted #45299 to become maintainer for this module (thank you for approving that PR).

However, I can't seem to merge/approve this PR, is there something else I need to do? I submitted this PR before requesting to be a maintainer, so do I need to close it and re-submit?

Thanks,

@jose-delarosa
Copy link
Contributor Author

Also, how do I assign myself to issues that are already open against this module (like #45248)? Thanks.

@webknjaz
Copy link
Member

webknjaz commented Sep 7, 2018

@jose-delarosa you might want to go through this page explaining how to use bot: https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md#for-community-maintainers

@jose-delarosa
Copy link
Contributor Author

Thanks @webknjaz

@jose-delarosa
Copy link
Contributor Author

shipit

@jose-delarosa
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Sep 11, 2018

@ansibot
Copy link
Contributor

ansibot commented Sep 11, 2018

Components

lib/ansible/modules/remote_management/redfish/redfish_facts.py
support: community
maintainers: billdodd jose-delarosa mraineri tomasg2012

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): jose-delarosa
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@webknjaz
Copy link
Member

AFAIR you need two ship its from maintainers.

@billdodd
Copy link
Contributor

shipit

@jose-delarosa
Copy link
Contributor Author

mmh, 2nd shipit didn't help, unless the bot only checks intermittently?

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 11, 2018
@ansibot ansibot merged commit 197059b into ansible:devel Sep 11, 2018
@webknjaz
Copy link
Member

@jose-delarosa bot normally runs every 10 minutes and sometimes gets slow because of long task queues.

@webknjaz
Copy link
Member

oh, and it probably didn't count your first shipit (maybe it's a glitch or maybe you weren't yet recognized as a maintainer back when you posted that comment)

@webknjaz
Copy link
Member

@jose-delarosa so @mkrizek and I checked the bot's logic and we can confirm that two shipits are required, still, it's not clear why bot got stuck processing it. Maybe it was the last comment, which triggered bot to re-evaluate shipits and execute the action.

@jose-delarosa jose-delarosa deleted the jose_dev branch September 14, 2018 02:55
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants