-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the root URI to match the DMTF specification #45295
Conversation
@jborean93 I submitted #45299 to become maintainer for this module (thank you for approving that PR). However, I can't seem to merge/approve this PR, is there something else I need to do? I submitted this PR before requesting to be a maintainer, so do I need to close it and re-submit? Thanks, |
Also, how do I assign myself to issues that are already open against this module (like #45248)? Thanks. |
@jose-delarosa you might want to go through this page explaining how to use bot: https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md#for-community-maintainers |
Thanks @webknjaz |
shipit |
bot_status |
Componentslib/ansible/modules/remote_management/redfish/redfish_facts.py Metadatawaiting_on: maintainer |
AFAIR you need two |
shipit |
mmh, 2nd shipit didn't help, unless the bot only checks intermittently? |
@jose-delarosa bot normally runs every 10 minutes and sometimes gets slow because of long task queues. |
oh, and it probably didn't count your first shipit (maybe it's a glitch or maybe you weren't yet recognized as a maintainer back when you posted that comment) |
@jose-delarosa so @mkrizek and I checked the bot's logic and we can confirm that two |
SUMMARY
Very small update to root_uri variable so its definition matches the DMTF specification
ISSUE TYPE
(Not really a bug, just a small enhancement to be compliant)
COMPONENT NAME
redfish_facts
ANSIBLE VERSION
ADDITIONAL INFORMATION