Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meraki_network - Fix enabling my.meraki.com #45352

Merged
merged 2 commits into from
Sep 9, 2018
Merged

meraki_network - Fix enabling my.meraki.com #45352

merged 2 commits into from
Sep 9, 2018

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Sep 7, 2018

SUMMARY
  • A parameter of "no" wouldn't be picked up
  • Check for False in addition to whether it exists
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meraki_network

ANSIBLE VERSION
ansible 2.8.0.dev0 (meraki/fix_merakicom f27a1cf680) last updated 2018/09/07 09:49:04 (GMT -500)
  config file = None
  configured module search path = ['/Users/kbreit/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/kbreit/Documents/Programming/ansible/lib/ansible
  executable location = /Users/kbreit/Documents/Programming/ansible/bin/ansible
  python version = 3.5.4 (default, Feb 25 2018, 14:56:02) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]

@kbreit
Fix enabling my.meraki.com
f27a1cf 
- A parameter of "no" wouldn't be picked up
- Check for False in addition to whether it exists
@ansibot
Copy link
Contributor

ansibot commented Sep 7, 2018

cc @dagwieers
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Sep 7, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Sep 7, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Sep 8, 2018
@dagwieers dagwieers merged commit afbf72c into ansible:devel Sep 9, 2018
kbreit added a commit to kbreit/ansible that referenced this pull request Sep 10, 2018
@kbreit
meraki_network - Fix enabling my.meraki.com (ansible#45352)
8b08a17 
* Fix enabling my.meraki.com
- A parameter of "no" wouldn't be picked up
- Check for False in addition to whether it exists

* Clean up disable_my_meraki parameter check

(cherry picked from commit afbf72c)
abadger pushed a commit that referenced this pull request Sep 10, 2018
@kbreit @abadger
meraki_network - Fix enabling my.meraki.com (#45352)
07b87c2 
* Fix enabling my.meraki.com
- A parameter of "no" wouldn't be picked up
- Check for False in addition to whether it exists

* Clean up disable_my_meraki parameter check

(cherry picked from commit afbf72c)
@kbreit kbreit deleted the meraki/fix_merakicom branch February 1, 2019 04:13
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies meraki Cisco Meraki community module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbreit @ansibot @dagwieers @s-hertel