Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yum also parse obsolete package output #45365

Merged
merged 4 commits into from
Nov 6, 2018
Merged

yum also parse obsolete package output #45365

merged 4 commits into from
Nov 6, 2018

Conversation

maxamillion
Copy link
Contributor

Signed-off-by: Adam Miller admiller@redhat.com

SUMMARY

This is a rebase of the patch originally proposed in
#40001 by machacekondra

Fixes #39978

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yum

ANSIBLE VERSION
ansible 2.8.0.dev0 (modules/yum b0798d768a) last updated 2018/09/07 14:45:36 (GMT -500)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/admiller/src/dev/ansible/lib/ansible
  executable location = /home/admiller/src/dev/ansible/bin/ansible
  python version = 2.7.15 (default, May 16 2018, 17:50:09) [GCC 8.1.1 20180502 (Red Hat 8.1.1-1)]

@ansibot
Copy link
Contributor

ansibot commented Sep 7, 2018

cc @Akasurde @berenddeschouwer @kustodian @verm666
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 7, 2018
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Sep 7, 2018
@maxamillion
yum also parse obsolete package output
d99bcf1 
This is a rebase of the patch originally proposed in
ansible#40001 by machacekondra

Fixes ansible#39978

Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion
properly parse the obsoletes, provide a new output entry, add changelog
3d85b6f 
Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot ansibot added test This PR relates to tests. and removed owner_pr This PR is made by the module's maintainer. labels Sep 11, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 11, 2018

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

test/units/modules/packaging/os/test_yum.py:132:42: E128 continuation line under-indented for visual indent
test/units/modules/packaging/os/test_yum.py:136:41: E128 continuation line under-indented for visual indent
test/units/modules/packaging/os/test_yum.py:137:41: E128 continuation line under-indented for visual indent
test/units/modules/packaging/os/test_yum.py:200:57: E226 missing whitespace around arithmetic operator

click here for bot help

@maxamillion
make pep8 happy
c569568 
Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion
remove q debugging output
107d3f6 
Signed-off-by: Adam Miller <admiller@redhat.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 11, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 19, 2018
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Oct 13, 2018
@maxamillion
Copy link
Contributor Author

rebuild_merge

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 6, 2018
@ansibot ansibot merged commit 091fb1d into ansible:devel Nov 6, 2018
@mwperina
Copy link
Contributor

mwperina commented Nov 7, 2018

Is it possible to backport this change to 2.7.z?

maxamillion added a commit to maxamillion/ansible that referenced this pull request Nov 7, 2018
@maxamillion
yum also parse obsolete package output (ansible#45365)
aba7296 
* yum also parse obsolete package output

This is a rebase of the patch originally proposed in
ansible#40001 by machacekondra

Fixes ansible#39978

Signed-off-by: Adam Miller <admiller@redhat.com>

* properly parse the obsoletes, provide a new output entry, add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>

* make pep8 happy

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove q debugging output

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 091fb1d)
@maxamillion maxamillion mentioned this pull request Nov 7, 2018
Merged
abadger pushed a commit that referenced this pull request Nov 9, 2018
@maxamillion @abadger
yum also parse obsolete package output (#45365)
4156d01 
* yum also parse obsolete package output

This is a rebase of the patch originally proposed in
#40001 by machacekondra

Fixes #39978

Signed-off-by: Adam Miller <admiller@redhat.com>

* properly parse the obsoletes, provide a new output entry, add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>

* make pep8 happy

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove q debugging output

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit 091fb1d)
mjmayer pushed a commit to mjmayer/ansible that referenced this pull request Nov 30, 2018
@maxamillion @mjmayer
yum also parse obsolete package output (ansible#45365)
c92a2fe 
* yum also parse obsolete package output

This is a rebase of the patch originally proposed in
ansible#40001 by machacekondra

Fixes ansible#39978

Signed-off-by: Adam Miller <admiller@redhat.com>

* properly parse the obsoletes, provide a new output entry, add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>

* make pep8 happy

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove q debugging output

Signed-off-by: Adam Miller <admiller@redhat.com>
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@maxamillion @Tomorrow9
yum also parse obsolete package output (ansible#45365)
2cce788 
* yum also parse obsolete package output

This is a rebase of the patch originally proposed in
ansible#40001 by machacekondra

Fixes ansible#39978

Signed-off-by: Adam Miller <admiller@redhat.com>

* properly parse the obsoletes, provide a new output entry, add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>

* make pep8 happy

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove q debugging output

Signed-off-by: Adam Miller <admiller@redhat.com>
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yum: Don't list obsoleted packages
6 participants
@maxamillion @ansibot @mwperina @mkrizek @dagwieers @s-hertel