Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in container registry documentation #45390

Merged
merged 2 commits into from
Sep 10, 2018
Merged

Fixes in container registry documentation #45390

merged 2 commits into from
Sep 10, 2018

Conversation

zikalino
Copy link
Contributor

@zikalino zikalino commented Sep 8, 2018

SUMMARY

This PR adds missing tags to return value, and one more small improvement.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

azure_rm_containerregistry_facts

ANSIBLE VERSION

2.7

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 8, 2018

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 azure cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Sep 8, 2018
@ansibleazurebot ansibleazurebot mentioned this pull request Sep 9, 2018
Closed
yuwzho
yuwzho suggested changes Sep 10, 2018
View reviewed changes
lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py
@@ -130,6 +130,10 @@
returned: when registry exists and C(admin_user_enabled) is set
type: str
sample: pass2value
tags:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The init method is

ansible/lib/ansible/modules/cloud/azure/azure_rm_containerregistry_facts.py

Line 177 in 4ca12e1

super(AzureRMContainerRegistryFacts, self).__init__(self.module_arg_spec, supports_tags=False)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's correct, because supports_tags is only for main modules, right?

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Sep 10, 2018
@yuwzho
Copy link
Contributor

yuwzho commented Sep 10, 2018

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 10, 2018
@ansibot ansibot merged commit 6110163 into ansible:devel Sep 10, 2018
@yuwzho yuwzho deleted the containere-registry-doc-fix branch September 10, 2018 06:05
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuwzho yuwzho yuwzho approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. azure cloud docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zikalino @ansibot @yuwzho