Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: Handle duplicate VM names in vmware_vm_facts #45412

Merged
merged 1 commit into from
Feb 12, 2019
Merged

VMware: Handle duplicate VM names in vmware_vm_facts #45412

merged 1 commit into from
Feb 12, 2019

Conversation

Akasurde
Copy link
Member

SUMMARY

This fix changes facts returned from vmware_vm_facts to list of dict from
dict of dict.

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docs/docsite/rst/porting_guides/porting_guide_2.8.rst
lib/ansible/modules/cloud/vmware/vmware_vm_facts.py
test/integration/targets/vmware_vm_facts/tasks/main.yml

ANSIBLE VERSION
2.8-devel

@ansibot
Copy link
Contributor

ansibot commented Sep 10, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_vm_facts.py:181:21: E126 continuation line over-indented for hanging indent

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Sep 10, 2018

cc @acozine @dav1x @warthog9
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 ci_verified Changes made in this PR are causing tests to fail. cloud docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. vmware VMware community labels Sep 10, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 10, 2018
@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Sep 10, 2018
@acozine acozine added this to To do in OLD Ansible Documentation via automation Sep 17, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 18, 2018
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Sep 27, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 21, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Dec 29, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 22, 2019
@Akasurde
VMware: Handle duplicate VM names in vmware_vm_facts
43cc9c0 
This fix changes facts returned from vmware_vm_facts to list of dict from
dict of dict.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 4, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 12, 2019
@Akasurde Akasurde closed this Feb 12, 2019
@Akasurde Akasurde reopened this Feb 12, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 12, 2019
@Akasurde Akasurde merged commit fab815f into ansible:devel Feb 12, 2019
@Akasurde Akasurde deleted the i44681 branch February 12, 2019 11:01
@Tomorrow9 Tomorrow9 mentioned this pull request Feb 13, 2019
Closed
Akasurde added a commit to Akasurde/ansible that referenced this pull request Feb 13, 2019
@Akasurde
Fix test case in vmware_guest
057a3ed 
Due to changes in ansible#45412
vmware_guest testcase delete_vm failed. This patch will fix that testcase.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this pull request Feb 13, 2019
Merged
pull bot pushed a commit to yaplej/ansible that referenced this pull request Feb 13, 2019
@Akasurde
Fix test case in vmware_guest (ansible#52142)
928c4f0 
Due to changes in ansible#45412
vmware_guest testcase delete_vm failed. This patch will fix that testcase.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@acozine acozine moved this from To do to Done in OLD Ansible Documentation Mar 7, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. vmware VMware community
Projects
No open projects
OLD Ansible Documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Akasurde @ansibot @samccann @bcoca @gundalow