Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Sangoma linux to hostname module #45430

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Add support for Sangoma linux to hostname module #45430

merged 1 commit into from
Sep 10, 2018

Conversation

imcdona
Copy link
Contributor

@imcdona imcdona commented Sep 10, 2018

SUMMARY

Add support for Sangoma linux which is derived from CentOS. Fixes 45300

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

hostname module

ANSIBLE VERSION
ansible 2.6.3
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /bin/ansible
  python version = 2.7.5 (default, Apr 11 2018, 07:36:10) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]
ADDITIONAL INFORMATION

I'm not sure that adding a class for every derivative of RedHat linux to the hostname module is the best course of action long term.

@imcdona imcdona changed the title Add Sangoma linux Add support for Sangoma linux to hostname module Sep 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 10, 2018

cc @alikins @saito-hideki
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Sep 10, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 10, 2018
@bcoca bcoca merged commit 371d959 into ansible:devel Sep 10, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hostname module cannot be used on platform Linux (Derived from red hat enterprise linux )
3 participants
@imcdona @ansibot @bcoca