clarify registered vs facts #45432
Merged
clarify registered vs facts #45432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
|
To ask to have registered variables be delegated as facts, is it an overkill? |
|
not something i would do under delegated facts as they are not facts |
acozine
reviewed
Sep 13, 2018
| Registered variables are valid on the host the remainder of the playbook run, which is the same as the lifetime of "facts" | ||
| in Ansible. Effectively registered variables are just like facts. | ||
| Registered variables are valid on the host the remainder of the playbook run, which is similar to the lifetime of "facts" in Ansible. | ||
| Both registered variables and facts are host level variables, but they are not the same thing. |
There was a problem hiding this comment.
How do registered variables differ from facts? Where is a user most likely to run into that difference?
There was a problem hiding this comment.
Several ways, but the main ones are:
- precedence: they follow different priorities
- caching: facts are backed by the 'configured cache plugin' vs registered vars are always just kept 'in memory'
There was a problem hiding this comment.
Can the suggested text include the precedence and caching details?
The text "which is similar to the lifetime of "facts" in Ansible." does not clarify the validity for me.
Suggested change
| Both registered variables and facts are host level variables, but they are not the same thing. | |
| Registered variables are valid on the host the remainder of the playbook run. |
The text "but they are not the same thing." also does not help me.
Suggested change
| Both registered variables and facts are host level variables, but they are not the same thing. | |
| Both registered variables and facts are host level variables. |
ansibot
added
the
stale_ci
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
ansibot
added
the
core_review
ansibot
removed
the
stale_ci
|
I consider this is already an improvement on the text. |
acozine
force-pushed
the
register_not_facts
branch
from
431859f
to
4b88d1f
Compare
samccann
approved these changes
Nov 29, 2018
kbreit
pushed a commit
to kbreit/ansible
that referenced
this pull request
Jan 11, 2019
* clarify registered vs facts fixes ansible#45411 * wordsmithing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fixes #45411
ISSUE TYPE
COMPONENT NAME
docs
ANSIBLE VERSION