Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_say - fix up syntax and test issues #45450

Merged
merged 1 commit into from
Sep 10, 2018
Merged

win_say - fix up syntax and test issues #45450

merged 1 commit into from
Sep 10, 2018

Conversation

jborean93
Copy link
Contributor

@jborean93 jborean93 commented Sep 10, 2018 •
edited

SUMMARY

Fix syntax issue in win_say and get broken tests working. Technically the tests work but will start failing with #45334 due to the trap that is added. This trap picks up the current silent failure in CI when the speech package is not available.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_say

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Sep 10, 2018

cc @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community labels Sep 10, 2018
@jborean93 jborean93 merged commit c9c141f into ansible:devel Sep 10, 2018
@jborean93 jborean93 deleted the win_say-fixes branch September 10, 2018 22:24
jborean93 added a commit to jborean93/ansible that referenced this pull request Sep 10, 2018
@jborean93
win_say - fix up syntax and test issues (ansible#45450)
11af8e5 
(cherry picked from commit c9c141f)
jborean93 added a commit to jborean93/ansible that referenced this pull request Sep 10, 2018
@jborean93
win_say - fix up syntax and test issues (ansible#45450)
6749d8f 
(cherry picked from commit c9c141f)
This was referenced Sep 10, 2018
Merged
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.6 - #45453
stable-2.7 - #45454

abadger pushed a commit that referenced this pull request Sep 11, 2018
@jborean93 @abadger
win_say - fix up syntax and test issues (#45450)
f2d5954 
(cherry picked from commit c9c141f)
@webknjaz webknjaz removed needs_triage Needs a first human triage before being processed. labels Sep 11, 2018
mattclay pushed a commit that referenced this pull request Sep 25, 2018
@jborean93 @mattclay
win_say - fix up syntax and test issues (#45450)
cd8208a 
(cherry picked from commit c9c141f)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @webknjaz