Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lenovo doc update #45483

Merged
merged 16 commits into from
Sep 14, 2018
Merged

Lenovo doc update #45483

merged 16 commits into from
Sep 14, 2018

Conversation

amuraleedhar
Copy link
Contributor

SUMMARY

In this PR I am adding documentation for ENOS and CNOS. platform_enos.rst and platform_cnos.rst are added that will come as hyperlink to those entries in index

ISSUE TYPE
  • Documentation Pull Request
COMPONENT NAME

docs/docsite/rst/network/user_guide/platform_index.rst
docs/docsite/rst/network/user_guide/platform_cnos.rst
docs/docsite/rst/network/user_guide/platform_enos.rst

ANSIBLE VERSION

ansible 2.7.0.dev0 (devel f9cbdcd) last updated 2018/07/03 14:55:43 (GMT +550)
config file = /etc/ansible/ansible.cfg
configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
ansible python module location = /home/ansible/sheru/ansible/lib/ansible
executable location = /home/ansible/sheru/ansible/bin/ansible
python version = 2.7.6 (default, Nov 23 2017, 15:49:48) [GCC 4.8.4]

ADDITIONAL INFORMATION

None.

@ansibot
Copy link
Contributor

ansibot commented Sep 11, 2018

cc @Qalthos @acozine @dkasberg @ganeshrn @gdpak @gundalow @justjais @rcarrillocruz @samccann @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 11, 2018
@ansibot ansibot removed core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 11, 2018
@amuraleedhar amuraleedhar mentioned this pull request Sep 11, 2018
Closed
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Sep 11, 2018
@samccann
Copy link
Contributor

Thanks for updating the documentation! I'll take a look and get back to you if I find any issues.

samccann
samccann reviewed Sep 12, 2018
View reviewed changes
docs/docsite/rst/network/user_guide/platform_enos.rst Outdated Show resolved Hide resolved
docs/docsite/rst/network/user_guide/platform_enos.rst Outdated Show resolved Hide resolved
docs/docsite/rst/network/user_guide/platform_cnos.rst Outdated
CNOS Platform Options
***************************************

CNOS supports Enable Mode (Privilege Escalation). This page offers details on how to use Enable Mode on CNOS in Ansible 2.7.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gundalow @privateip Is there any reason we should keep a specific version in these platform guides?
@amuraleedhar This version says 2.7 but the settings by platform table entries say this is supported as of 2.5. Let's see what the other two folks say, but I think we can remove the specific version in this intro sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing 2.7 now

docs/docsite/rst/network/user_guide/platform_cnos.rst Outdated

For legacy playbooks, CNOS still supports ``ansible_connection: local``. We recommend modernizing to use ``ansible_connection: network_cli`` as soon as possible.

Using CLI in Ansible 2.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue, if the others agree, remove 2.7 here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other vendors say ios, eos, junos all are putting the version 2.6 there. So I too followed the same. I feel it make sense to remove version from there. Whether to use network_cli or local is the confusion point for user, then he may refer the table in the platform_index.rst. I am waiting for Gundalow and/or privateip to respond.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm thinking I need to go back in and remove 2.6 from all the others as well. But let's see if @gundalow, @privateip agree.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chatted with @gundalow in slack and he is okay with removing the version. I will go back and remove the 2.6 version from the other guides in #45630

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove 2.7 from every where now.
Thanks
-Anil

@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 14, 2018
@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 14, 2018
@samccann samccann merged commit 4ec317c into ansible:devel Sep 14, 2018
@samccann samccann mentioned this pull request Sep 19, 2018
Merged
@samccann samccann added this to Docsite work in Ansible-maintained Collections Documentation via automation Sep 21, 2018
@samccann samccann moved this from Needs Triage - todo backlog - Docsite work -anything can go here to Done in Ansible-maintained Collections Documentation Mar 7, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann approved these changes

Assignees

@samccann samccann

Labels
affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Ansible-maintained Collections Docume...
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amuraleedhar @ansibot @samccann @gundalow