Ovirt delete snapshots after x days #45551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
|
The test The test |
ansibot
added
ci_verified
ansibot
added
community_review
jborean93
removed
the
needs_triage
| keep_days_old: | ||
| description: | ||
| - "Number of days after which should snapshot be deleted." | ||
| - "It will check all snapshots of vm and delete them, if they are older." |
There was a problem hiding this comment.
s/vm/virtual machine
ansibot
added
core_review
| except Exception as e: | ||
| module.fail_json(msg=str(e), exception=traceback.format_exc()) | ||
| finally: | ||
| if module.params.get('keep_days_old') is not None: |
There was a problem hiding this comment.
In this case we wouldn't close the connection. Please create new method something like remove_old_snapshosts and call it from state=='present' branch as it's default state. Also please document what will be returned in case this paramter is used.
ansibot
added
the
stale_ci
ansibot
added
community_review
| @@ -112,6 +122,10 @@ | |||
| at following url: http://ovirt.github.io/ovirt-engine-api-model/master/#types/snapshot." | |||
| returned: On success if snapshot is found. | |||
| type: dict | |||
| snapshots: | |||
| description: List of deleted snapshots | |||
There was a problem hiding this comment.
Please also document that it's returned only in case user specify keep_days_old parameter.
| @@ -222,6 +236,23 @@ def restore_snapshot(module, vm_service, snapshots_service): | |||
| } | |||
|
|
|||
|
|
|||
| def remove_old_snapshosts(module, snapshots_service): | |||
| from datetime import datetime | |||
There was a problem hiding this comment.
Please do this import at the begging of the file with other imports.
| changed = False | ||
| date_now = datetime.now() | ||
| for snapshot in snapshots_service.list(): | ||
| if snapshot.vm and snapshot.vm.name == module.params.get('vm_name'): |
There was a problem hiding this comment.
I think it should be just fine to check if snapshot.vm is not None because you are already using snapshots_service of that vm, so you don't need to check if names are same.
| snapshots_service.snapshot_service(snapshot.id).remove() | ||
| deleted_snapshot.append(get_dict_of_struct(snapshot)) | ||
| changed = True | ||
| time.sleep(45) |
There was a problem hiding this comment.
We need to wait until snaphsot is removed and vm ready to remove another snapshot, not any random wait time.
ansibot
added
automerge
dagwieers
added
ovirt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #41500
ISSUE TYPE
COMPONENT NAME
ovirt
ANSIBLE VERSION
ADDITIONAL INFORMATION