Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude the whole ansible_failed_task block #45587

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Exclude the whole ansible_failed_task block #45587

merged 1 commit into from
Sep 13, 2018

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Sep 12, 2018

It has lots of FieldAttributes that won't serialize.
Also the connection doesn't care.

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ANSIBLE VERSION
2.8

@Qalthos
Exclude the whole ansible_failed_task block
10a04b9 
It has lots of FieldAttributes that won't serialize.
Also the connection doesn't care.
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 12, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 13, 2018
@Qalthos Qalthos merged commit 3d0f19d into ansible:devel Sep 13, 2018
@Qalthos Qalthos deleted the dont-fail-on-fail branch September 13, 2018 01:17
Qalthos added a commit to Qalthos/ansible that referenced this pull request Sep 13, 2018
@Qalthos
[2.7] Exclude the whole ansible_failed_task block (ansible#45587)
e58d080 
It has lots of FieldAttributes that won't serialize.
Also the connection doesn't care.
(cherry picked from commit 3d0f19d)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
abadger pushed a commit that referenced this pull request Sep 13, 2018
@Qalthos @abadger
[2.7] Exclude the whole ansible_failed_task block (#45587)
b52148d 
It has lots of FieldAttributes that won't serialize.
Also the connection doesn't care.
(cherry picked from commit 3d0f19d)

Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Sep 13, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@privateip privateip privateip approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Qalthos @privateip @bcoca @ansibot