Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTD HttpApi Plugin: Fix refresh token issue #45598

Merged
merged 1 commit into from
Sep 13, 2018
Merged

FTD HttpApi Plugin: Fix refresh token issue #45598

merged 1 commit into from
Sep 13, 2018

Conversation

annikulin
Copy link
Contributor

@annikulin annikulin commented Sep 13, 2018 •
edited

SUMMARY

This PR fixes the problem when a token was not properly refreshed and Ansible playbooks failed when the access token expired.

send method from the httpapi.py connection retries the request by calling self.send(path, data, **kwargs) and thus Authorization header should be a part of _auth property rather than passed directly.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

FTD HttpApi Plugin

ANSIBLE VERSION
2.7

@ansibot
Copy link
Contributor

ansibot commented Sep 13, 2018

cc @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 13, 2018
@gdpak gdpak merged commit b7263ea into ansible:devel Sep 13, 2018
@annikulin annikulin mentioned this pull request Sep 13, 2018
Merged
@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Sep 13, 2018
abadger pushed a commit that referenced this pull request Oct 9, 2018
@annikulin @abadger
[stable-2.7] Store Authorization header inside HttpApi connection plu…
d2c7204 
…gin (#45598) (#45608)

* Store Authorization header inside HttpApi connection plugin (#45598)


(cherry picked from commit b7263ea)

* Add changelog entry
@dagwieers dagwieers added the cisco Cisco technologies label Mar 4, 2019
@dagwieers dagwieers added the ftd Cisco FTD community label Mar 19, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies ftd Cisco FTD community networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@annikulin @ansibot @dagwieers @bcoca @gdpak