Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow jinja2 unique filter compat #45637

Merged
merged 7 commits into from
Sep 25, 2018
Merged

allow jinja2 unique filter compat #45637

merged 7 commits into from
Sep 25, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Sep 13, 2018

SUMMARY

Fixes #45286

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

filters/unique

ANSIBLE VERSION
2.x

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 13, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Sep 14, 2018
@mkrizek
Copy link
Contributor

mkrizek commented Sep 14, 2018

cc @sivel

@sivel
Copy link
Member

sivel commented Sep 14, 2018

We should probably also validate whether the user has provided one of the new args and HAS_UNIQUE is False. Otherwise the filter would just continue, but without really doing what they asked for.

@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 14, 2018
@bcoca
handle j2 specific params
95307a9 
also normalized on how we normally import and use exceptoins
@mattclay

This comment has been minimized.

Sign in to view
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Sep 14, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Sep 15, 2018
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Sep 15, 2018
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Sep 17, 2018
@bcoca bcoca merged commit 32ec69d into ansible:devel Sep 25, 2018
@bcoca bcoca deleted the j2_unique branch September 25, 2018 18:27
@bcoca bcoca mentioned this pull request Nov 7, 2018
Closed
@sivel sivel mentioned this pull request Jan 9, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible unique filter shadows Jinja2 unique filter
5 participants
@bcoca @mkrizek @sivel @mattclay @ansibot