Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add scaleway security group module #45686

Merged
merged 1 commit into from
Sep 25, 2018
Merged

feat: add scaleway security group module #45686

merged 1 commit into from
Sep 25, 2018

Conversation

abarbare
Copy link
Contributor

SUMMARY

This module implements the scaleway Security Group management module.
It allows user to:

  • create a Security Group
  • delete a Security Group
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

scaleway_security_group

ANSIBLE VERSION
ansible 2.8.0.dev0 (security_groups f11c86630c) last updated 2018/09/16 12:12:24 (GMT +200)
  config file = /Users/abarbare/.ansible.cfg
  configured module search path = [u'/Users/abarbare/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/abarbare/Documents/ansible/lib/ansible
  executable location = /Users/abarbare/Documents/ansible/bin/ansible
  python version = 2.7.15 (default, Jul 23 2018, 21:27:06) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

@ansibot
Copy link
Contributor

ansibot commented Sep 16, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. scaleway support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Sep 16, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 16, 2018

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 99, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:238:0: missing-final-newline Final newline missing

The test ansible-test sanity --test botmeta [explain] failed with 1 error:

.github/BOTMETA.yml:38:3: YAML load failed: while parsing a block mapping in ".github/BOTMETA.yml", line 38, column 3 expected <block end>, but found '<block mapping start>' in ".github/BOTMETA.yml", line 1034, column 5

The test ansible-test sanity --test pep8 [explain] failed with 12 errors:

lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:55:17: W291 trailing whitespace
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:85:17: W291 trailing whitespace
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:127:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:134:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:143:22: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:163:41: E222 multiple spaces after operator
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:178:22: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:193:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:199:34: E241 multiple spaces after ':'
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:200:35: E241 multiple spaces after ':'
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:201:32: E241 multiple spaces after ':'
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:238:11: W292 no newline at end of file

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

.github/BOTMETA.yml:1034:5: error syntax error: expected <block end>, but found '<block mapping start>'
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:84:9: error DOCUMENTATION: syntax error: could not find expected ':'

The test ansible-test sanity --test validate-modules [explain] failed with 11 errors:

lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: E319 RETURN.data.scaleway_security_group: extra keys not allowed @ data['scaleway_security_group']. Got {'description': 'my security group description', 'enable_default_security': True, 'id': '0168fb1f-cc46-4f69-b4be-c95d2a19bcae', 'inbound_default_policy': 'accept', 'name': 'security_group', 'organization': '43a3b6c8-916f-477b-b7ec-ff1898f5fdd9', 'organization_default': False, 'outbound_default_policy': 'accept', 'servers': [], 'stateful': False}
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: E324 Value for "default" from the argument_spec ('https://api.scaleway.com') for "api_url" does not match the documentation (None)
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: E324 Value for "default" from the argument_spec ('present') for "state" does not match the documentation (None)
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: E324 Value for "default" from the argument_spec (30) for "api_timeout" does not match the documentation (None)
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: E324 Value for "default" from the argument_spec (True) for "validate_certs" does not match the documentation (False)
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: E325 argument_spec for "validate_certs" defines type="bool" but documentation does not
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: E326 Value for "choices" from the argument_spec (['absent', 'present']) for "state" does not match the documentation ([])
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: E326 Value for "choices" from the argument_spec (['accept', 'drop']) for "inbound_default_policy" does not match the documentation ([])
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: E326 Value for "choices" from the argument_spec (['accept', 'drop']) for "outbound_default_policy" does not match the documentation ([])
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:0:0: E326 Value for "choices" from the argument_spec (['par1', 'EMEA-FR-PAR1', 'ams1', 'EMEA-NL-EVS']) for "region" does not match the documentation ([])
lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:84:9: E302 DOCUMENTATION is not valid YAML

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 16, 2018
@abarbare abarbare force-pushed the security_groups branch 2 times, most recently from 40c0bf8 to e7a5a87 Compare September 16, 2018 11:34
@mscherer mscherer removed the needs_triage Needs a first human triage before being processed. label Sep 16, 2018
@ansibot
Copy link
Contributor

ansibot commented Sep 16, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/scaleway/scaleway_security_group.py:158:38: E127 continuation line over-indented for visual indent

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/legacy/roles/scaleway_security_group/tasks/main.yml:88:1: error syntax error: expected <block end>, but found '?'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 16, 2018
@pilou-
Copy link
Contributor

pilou- commented Sep 16, 2018

peer reviewed with submitter and tested with my own credentials.

LGTM

@pilou-
Copy link
Contributor

pilou- commented Sep 16, 2018

LGTM :)

@mscherer
Copy link
Contributor

shipit

@pilou-
Copy link
Contributor

pilou- commented Sep 21, 2018

@abarbare a rebase is required

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 21, 2018
feat: add scaleway security group module
549b1b3 
fix: pep8 coding style

fix: error order requests
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 21, 2018
@abarbare
Copy link
Contributor Author

Hello @gundalow can you have a look on this one ?
Thanks

@abarbare
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Sep 23, 2018

Components

.github/BOTMETA.yml
support: core
maintainers:

lib/ansible/modules/cloud/scaleway/scaleway_security_group.py
support: community
maintainers:

test/legacy/roles/scaleway_security_group/defaults/main.yml
support: core
maintainers:

test/legacy/roles/scaleway_security_group/tasks/main.yml
support: core
maintainers:

test/legacy/scaleway.yml
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@pilou-
Copy link
Contributor

pilou- commented Sep 23, 2018

shipit

1 similar comment
@mscherer
Copy link
Contributor

shipit

@gundalow gundalow merged commit 98b0594 into ansible:devel Sep 25, 2018
@gundalow
Copy link
Contributor

Thank you all for the code and reviews. Merged into devel for release in Ansible 2.8

@dagwieers dagwieers added the botmeta This PR modifies the BOTMETA.yml and this requires special attention! label Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mscherer mscherer mscherer left review comments

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 botmeta This PR modifies the BOTMETA.yml and this requires special attention! cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. new_module This PR includes a new module. new_plugin This PR includes a new plugin. scaleway support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@abarbare @ansibot @pilou- @mscherer @gundalow @dagwieers