Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for platform grouping in Netbox dynamic inventory plugin #45733

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Add support for platform grouping in Netbox dynamic inventory plugin #45733

merged 1 commit into from
Oct 17, 2018

Conversation

remyleone
Copy link
Contributor

SUMMARY

Add support for platform grouping

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • lib/ansible/plugins/inventory/netbox.py
ANSIBLE VERSION
ansible 2.8.0.dev0 (netbox_platform f8be198350) last updated 2018/09/17 17:01:50 (GMT +200)
  config file = None
  configured module search path = [u'/Users/sieben/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/sieben/workspace/ansible/lib/ansible
  executable location = /Users/sieben/workspace/ansible/bin/ansible
  python version = 2.7.15 (default, Jun 17 2018, 12:46:58) [GCC 4.2.1 Compatible Apple LLVM 9.1.0 (clang-902.0.39.2)]

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. inventory Inventory category needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 17, 2018
@remyleone remyleone changed the title Add support for platform grouping Add support for platform grouping in Netbox dynamic inventory plugin Sep 18, 2018
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Sep 18, 2018
@remyleone
Copy link
Contributor Author

Could this be merged?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 5, 2018
@remyleone
Copy link
Contributor Author

@gundalow Could this be merged?

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 8, 2018
@remyleone
Copy link
Contributor Author

@Anthony25 Could you review?

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 12, 2018

cc @Anthony25 @FragmentedPacket @nikkytub @pilou-
click here for bot help

@remyleone
Copy link
Contributor Author

LGTM

1 similar comment
@aruhier
Copy link
Contributor

aruhier commented Oct 15, 2018

LGTM

@remyleone
Copy link
Contributor Author

@gundalow Could it be merged?

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Oct 15, 2018
@gundalow gundalow merged commit 8a7a819 into ansible:devel Oct 17, 2018
@gundalow
Copy link
Contributor

Merged into devel for release in Ansible 2.8

Thank you for the PR and reviews!

Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@remyleone @Tomorrow9
Add support for platform grouping (ansible#45733)
7d10cbe
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aruhier aruhier aruhier approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. inventory Inventory category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@remyleone @ansibot @aruhier @gundalow @ryansb