Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

These won't get upgraded to bool if ansible doesn't know they are #45736

Merged
merged 1 commit into from Sep 17, 2018
Merged

These won't get upgraded to bool if ansible doesn't know they are #45736

merged 1 commit into from Sep 17, 2018

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Sep 17, 2018

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

httpapi

ANSIBLE VERSION
2.8

Qalthos added a commit to Qalthos/ansible that referenced this pull request Sep 17, 2018
@Qalthos
These won't get upgraded to bool if ansible doesn't know they are
09b73c9 
Adapted from ansible#45736, the other change came from a commit that will not
be backported
@Qalthos Qalthos mentioned this pull request Sep 17, 2018
Merged
@ansibot
Copy link
Contributor

ansibot commented Sep 17, 2018

cc @NilashishC @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 17, 2018
Qalthos added a commit to Qalthos/ansible that referenced this pull request Sep 17, 2018
@Qalthos
These won't get upgraded to bool if ansible doesn't know they are
f118afb 
Inspired by ansible#45736, but that var doesn't exist yet, so label the one
that does exist.
@Qalthos Qalthos mentioned this pull request Sep 17, 2018
Merged
@Qalthos Qalthos merged commit 917fcb9 into ansible:devel Sep 17, 2018
@Qalthos Qalthos deleted the typed-conn-vars branch September 17, 2018 15:35
@webknjaz webknjaz removed needs_triage Needs a first human triage before being processed. labels Sep 19, 2018
abadger pushed a commit that referenced this pull request Sep 19, 2018
@Qalthos @abadger
These won't get upgraded to bool if ansible doesn't know they are
79cebbf 
Adapted from #45736, the other change came from a commit that will not
be backported
mattclay pushed a commit that referenced this pull request Sep 25, 2018
@Qalthos @mattclay
These won't get upgraded to bool if ansible doesn't know they are
395b30c 
Inspired by #45736, but that var doesn't exist yet, so label the one
that does exist.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. networking Network category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Qalthos @ansibot @webknjaz