Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed a comment on previous PR #45743

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Missed a comment on previous PR #45743

merged 1 commit into from
Sep 17, 2018

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Sep 17, 2018

SUMMARY

That was a good point

ISSUE TYPE
  • Nitpick Pull Request
COMPONENT NAME

NetworkConnectionBase

ANSIBLE VERSION
2.8

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 17, 2018
@Qalthos Qalthos merged commit 52c20bb into ansible:devel Sep 17, 2018
@Qalthos Qalthos deleted the quick branch September 17, 2018 19:39
@webknjaz webknjaz removed needs_triage Needs a first human triage before being processed. labels Sep 19, 2018
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Qalthos @webknjaz @ansibot