[aws unit test utils] only create a recordings directory when the env var is set #45752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariable PLACEBO_RECORD is set
ansibot
added
affects_2.8
s-hertel
removed
the
needs_triage
mattclay
reviewed
Sep 17, 2018
| raise | ||
| if not os.getenv('PLACEBO_RECORD'): | ||
| if not os.path.isdir(recordings_path): | ||
| raise NotImplementedError |
There was a problem hiding this comment.
I'd include a message, something like:
raise Exception('Missing Placebo recordings in directory: %s' % recordings_path)
ryansb
approved these changes
Sep 17, 2018
mattclay
approved these changes
Sep 17, 2018
s-hertel
added a commit
to s-hertel/ansible
that referenced
this pull request
Sep 17, 2018
… var is set (ansible#45752) * Only create placebo recording test directories when the environment variable PLACEBO_RECORD is set (cherry picked from commit 5467ac3)
s-hertel
added a commit
to s-hertel/ansible
that referenced
this pull request
Sep 17, 2018
… var is set (ansible#45752) * Only create placebo recording test directories when the environment variable PLACEBO_RECORD is set (cherry picked from commit 5467ac3)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Only create placebo recording test directories when the environment variable PLACEBO_RECORD is set
ISSUE TYPE
COMPONENT NAME
test/units/utils/amazon_placebo_fixtures.py
ANSIBLE VERSION