Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vultr_server: fix diff for user data #45753

Merged
merged 1 commit into from
Sep 18, 2018
Merged

vultr_server: fix diff for user data #45753

merged 1 commit into from
Sep 18, 2018

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Sep 17, 2018

SUMMARY

fix diff for user data.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vultr_server

ANSIBLE VERSION
2.6
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Sep 17, 2018

cc @Spredzy
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 17, 2018
Spredzy
Spredzy approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@Spredzy Spredzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@Spredzy
Copy link
Contributor

Spredzy commented Sep 18, 2018

@resmo If not too late; do you mind adding a non-regression test?

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Sep 18, 2018
@resmo
Copy link
Contributor Author

resmo commented Sep 18, 2018

AFAIK there is no easy way for integration testing for diff. We should work towards unit testing. but this would be out of scope for this PR.

@resmo resmo merged commit 2298664 into ansible:devel Sep 18, 2018
@resmo resmo deleted the fix/vultr_server_diff_user_data branch September 18, 2018 21:20
@resmo resmo mentioned this pull request Sep 22, 2018
Merged
abadger pushed a commit that referenced this pull request Oct 9, 2018
@resmo @abadger
vultr_server: fix diff for user data (#45753)
0dec6db 
(cherry picked from commit 2298664)
@dagwieers dagwieers added the vultr Vultr community label Feb 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Spredzy Spredzy Spredzy approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. vultr Vultr community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@resmo @ansibot @Spredzy @dagwieers