Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing exceptions #45775

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Fix missing exceptions #45775

merged 2 commits into from
Oct 30, 2018

Conversation

wiorka
Copy link
Contributor

@wiorka wiorka commented Sep 18, 2018

SUMMARY

Replace non-existing OpenStackCloudTimeout exception. Fixes: #45151
Replace OpenStackCloudURINotFound that doesn't exist in the 'exceptions' module

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_volume
os_volume_snapshot
os_quota
os_server_volume

ANSIBLE VERSION
ansible-playbook 2.6.3
  config file = /Users/nowaka/git/nk2/nk2-ci-ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
  executable location = /usr/local/bin/ansible-playbook
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

Several modules refer to exceptions that don't exist in the openstacksdk exceptions module.

@ansibot
Copy link
Contributor

ansibot commented Sep 18, 2018

cc @dagnello @emonty @juliakreger @omgjlk @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. openstack support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 18, 2018
@opendev-zuul
Copy link

opendev-zuul bot commented Sep 18, 2018

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Sep 18, 2018
@mattclay
Copy link
Member

recheck

@opendev-zuul
Copy link

opendev-zuul bot commented Sep 20, 2018

Build succeeded (third-party-check pipeline).

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 28, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. and removed core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Oct 6, 2018
@mnaser
Copy link
Contributor

mnaser commented Oct 13, 2018

shipit

@mnaser
Copy link
Contributor

mnaser commented Oct 13, 2018

Thank you!!

@mnaser
Copy link
Contributor

mnaser commented Oct 13, 2018

Fixes #46261
Fixes #41240

This was referenced Oct 13, 2018
Closed
Closed
@wiorka wiorka closed this Oct 14, 2018
@wiorka wiorka reopened this Oct 14, 2018
@wiorka
Copy link
Contributor Author

wiorka commented Oct 14, 2018

Sorry for closing and reopening, a misclick.

@opendev-zuul
Copy link

opendev-zuul bot commented Oct 14, 2018

Build succeeded (third-party-check pipeline).

@mnaser
Copy link
Contributor

mnaser commented Oct 14, 2018

shipit

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 14, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 25, 2018
@ansibot
Copy link
Contributor

ansibot commented Oct 28, 2018

cc @cloudnull @evrardjp @odyssey4me
click here for bot help

@odyssey4me
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 30, 2018
@ansibot ansibot merged commit eb39c46 into ansible:devel Oct 30, 2018
@wiorka wiorka deleted the fix-missing-exceptions branch October 30, 2018 13:26
@gtema gtema mentioned this pull request Nov 5, 2018
Merged
abadger pushed a commit that referenced this pull request Nov 5, 2018
@gtema @abadger
fix missing exceptions openstack modules (#48088)
953568e 
* Fix missing exceptions (#45775)

* Replace non-existing OpenStackCloudTimeout exception. Fixes: #45151

* Replace OpenStackCloudURINotFound that doesn't exist in the 'exceptions' module

(cherry picked from commit eb39c46)

* add changelog
Tomorrow9 pushed a commit to Tomorrow9/ansible that referenced this pull request Dec 4, 2018
@wiorka @Tomorrow9
Fix missing exceptions (ansible#45775)
da89a17 
* Replace non-existing OpenStackCloudTimeout exception. Fixes: ansible#45151

* Replace OpenStackCloudURINotFound that doesn't exist in the 'exceptions' module
@satishdotpatel
Copy link

I am deploying openstack-ansible on CentOS 7.6 and having same issue look like issue still exist, I am running ansible 2.7.9

@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. openstack shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An exception occurred when using os_volume module
8 participants
@wiorka @ansibot @mattclay @mnaser @odyssey4me @satishdotpatel @ryansb @AnnaNowak-TomTom