Fixes #45417

[gustavomcarmo]

SUMMARY

Fixes #45417

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ldap_entry

ANSIBLE VERSION

2.7

[ansibot]

cc @jtyr
click here for bot help

[jtyr]

This doesn't seem to be the same thing:

In [1]: s = "abcdef"

In [2]: [map(str.upper, s)]
Out[2]: [['A', 'B', 'C', 'D', 'E', 'F']]

In [3]: [str.upper(v) for v in s]
Out[3]: ['A', 'B', 'C', 'D', 'E', 'F']

[gustavomcarmo]

For sure this is not the same thing. The first does not solve the issue.

[jtyr]

Right. I can see now what's happening. You previous fix changed this:

-attrs[name] = value
+attrs[name] = [map(to_bytes, value)]

Which is wrong as it creates list of list. So this PR is fixing that which is good but I would rather use this syntax than the for loop:

attrs[name] = map(to_bytes, value)

[gustavomcarmo]

I also prefer map instead of a loop, but when map(to_bytes, value) is used, as you've asked for, the following error happens:

The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_3kcj1hb2/ansible_module_ldap_entry.py", line 241, in main
    action()
  File "/tmp/ansible_3kcj1hb2/ansible_module_ldap_entry.py", line 157, in _add
    self.connection.add_s(self.dn, modlist)
  File "/home/gcarmo/.local/lib/python3.6/site-packages/ldap/ldapobject.py", line 428, in add_s
    return self.add_ext_s(dn,modlist,None,None)
  File "/home/gcarmo/.local/lib/python3.6/site-packages/ldap/ldapobject.py", line 413, in add_ext_s
    msgid = self.add_ext(dn,modlist,serverctrls,clientctrls)
  File "/home/gcarmo/.local/lib/python3.6/site-packages/ldap/ldapobject.py", line 410, in add_ext
    return self._ldap_call(self._l.add_ext,dn,modlist,RequestControlTuples(serverctrls),RequestControlTuples(clientctrls))
  File "/home/gcarmo/.local/lib/python3.6/site-packages/ldap/ldapobject.py", line 329, in _ldap_call
    reraise(exc_type, exc_value, exc_traceback)
  File "/home/gcarmo/.local/lib/python3.6/site-packages/ldap/compat.py", line 44, in reraise
    raise exc_value
  File "/home/gcarmo/.local/lib/python3.6/site-packages/ldap/ldapobject.py", line 313, in _ldap_call
    result = func(*args,**kwargs)
ldap.PARAM_ERROR: {'desc': 'Bad parameter to an ldap routine', 'matched': 'ou=people,dc=example,dc=org'}

We can investigate it or just assume the solution is ok.

[jtyr]

Try this:

attrs[name] = list(map(to_bytes, value))

[gustavomcarmo]

Could @Akasurde do it?

[jtyr]

You can add it into this PR.

[gustavomcarmo]

In which case the ldap_attr module goes wrong after the @Akasurde's PR #41248 ?

[gustavomcarmo]

@jtyr I've just found out how the ldap_attr module goes wrong after the @Akasurde's PR #41248. When adding a value to an attribute, the exception TypeError: object of type 'filter' has no len() is thrown, on line 183. The solution is values_to_add = list(filter(self._is_value_absent, self.values)) on line 181. I have not tested the value deletion, the same error may occur. I'll make a new PR soon.

[gustavomcarmo]

@jtyr @Akasurde @webknjaz I've just created the PR #46818 to fix the bug mentioned above.

[gustavomcarmo]

@Akasurde could you please review this PR and merge it?